diff options
author | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-12-03 18:17:16 +0000 |
---|---|---|
committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-12-03 18:17:16 +0000 |
commit | 3361471a3504ecd0351ff70f4c42d8d6fee963d4 (patch) | |
tree | 1886e770069303c70c588c396b2d9c19343e3adc /bench/GrMemoryPoolBench.cpp | |
parent | e3bb3bce3e9c1f3bc8ee779b1b3383c18e560bce (diff) |
Simplify benchmark internal API.
I'm not quite sure why I wrote such a convoluted API with setLoops()/getLoops().
This replaces it with a loops argument passed to onDraw().
This CL is largely mechanical translation from the old API to the new one.
MathBench used this->getLoops() outside onDraw(), which seems incorrect. I
fixed it.
BUG=
R=djsollen@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/99893003
git-svn-id: http://skia.googlecode.com/svn/trunk@12466 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'bench/GrMemoryPoolBench.cpp')
-rw-r--r-- | bench/GrMemoryPoolBench.cpp | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/bench/GrMemoryPoolBench.cpp b/bench/GrMemoryPoolBench.cpp index b692aae432..21f686d89d 100644 --- a/bench/GrMemoryPoolBench.cpp +++ b/bench/GrMemoryPoolBench.cpp @@ -41,7 +41,7 @@ protected: return "grmemorypool_stack"; } - virtual void onDraw(SkCanvas*) { + virtual void onDraw(const int loops, SkCanvas*) { SkRandom r; enum { kMaxObjects = 4 * (1 << 10), @@ -51,11 +51,11 @@ protected: // We delete if a random [-1, 1] fixed pt is < the thresh. Otherwise, // we allocate. We start allocate-biased and ping-pong to delete-biased SkFixed delThresh = -SK_FixedHalf; - const int kSwitchThreshPeriod = this->getLoops() / (2 * kMaxObjects); + const int kSwitchThreshPeriod = loops / (2 * kMaxObjects); int s = 0; int count = 0; - for (int i = 0; i < this->getLoops(); i++, ++s) { + for (int i = 0; i < loops; i++, ++s) { if (kSwitchThreshPeriod == s) { delThresh = -delThresh; s = 0; @@ -93,14 +93,14 @@ protected: return "grmemorypool_random"; } - virtual void onDraw(SkCanvas*) { + virtual void onDraw(const int loops, SkCanvas*) { SkRandom r; enum { kMaxObjects = 4 * (1 << 10), }; SkAutoTDelete<A> objects[kMaxObjects]; - for (int i = 0; i < this->getLoops(); i++) { + for (int i = 0; i < loops; i++) { uint32_t idx = r.nextRangeU(0, kMaxObjects-1); if (NULL == objects[idx].get()) { objects[idx].reset(new A); @@ -131,10 +131,10 @@ protected: return "grmemorypool_queue"; } - virtual void onDraw(SkCanvas*) { + virtual void onDraw(const int loops, SkCanvas*) { SkRandom r; A* objects[M]; - for (int i = 0; i < this->getLoops(); i++) { + for (int i = 0; i < loops; i++) { uint32_t count = r.nextRangeU(0, M-1); for (uint32_t i = 0; i < count; i++) { objects[i] = new A; |