diff options
| author |  msarett <msarett@google.com> | 2016-08-18 14:29:22 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-08-18 14:29:22 -0700 |
| commit | 7fc08585d0d4daada1c8600b6cdef970ee6c2369 (patch) | |
| tree | 0b39ac90f0f21f4496efef50c5fff1aed1f3302c /bench/DrawLatticeBench.cpp | |
| parent | 530032a18e373ee673ae96fdbfa1fae6292f8f08 (diff) | |
Revert of Batched implementation of drawLattice() for GPU (patchset #7 id:180001 of https://codereview.chromium.org/2255963002/ )
Reason for revert:
Things drawing weird.
Original issue's description:
> Batched implementation of drawLattice() for GPU
>
> Bechmarks (Nexus 6P):
>
> Src=100x100, Dst=250x250, NumRects=9
> Android 77.7us
> Skia (without patch) 57.2us
> Skia (with patch) 34.7us
>
> Src=100x100, Dst=500x500, NumRects=9
> Android 77.0us
> Skia (without patch) 56.9us
> Skia (with patch) 44.5us
>
> Src=100x100, Dst=1000x1000, NumRects=9
> Android 180us
> Skia (without patch) 96.8us
> Skia (with patch) 70.5us
>
> Src=100x100, Dst=250x250, NumRects=15
> Android 208us
> Skia (without patch) 155us
> Skia (with patch) 55.9us
>
> Src=100x100, Dst=500x500, NumRects=15
> Android 207us
> Skia (without patch) 152us
> Skia (with patch) 63.0us
>
> Src=100x100, Dst=1000x1000, NumRects=15
> Android 233us
> Skia (without patch) 156us
> Skia (with patch) 99.9us
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255963002
>
> Committed: https://skia.googlesource.com/skia/+/93242c4ae50dfcc0d922cdb3ba80bbc7b4bbe93d
TBR=bsalomon@google.com,reed@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2255683004
Diffstat (limited to 'bench/DrawLatticeBench.cpp')
| -rw-r--r-- | bench/DrawLatticeBench.cpp | 21 |
1 files changed, 3 insertions, 18 deletions
diff --git a/bench/DrawLatticeBench.cpp b/bench/DrawLatticeBench.cpp index 9c4d31a099..4c03ca1dfa 100644 --- a/bench/DrawLatticeBench.cpp +++ b/bench/DrawLatticeBench.cpp @@ -29,10 +29,6 @@ public: return fName.c_str(); } - SkIPoint onGetSize() override { - return SkIPoint::Make(1000, 1000); - } - bool isSuitableFor(Backend backend) override { return kRaster_Backend == backend || kGPU_Backend == backend; } @@ -58,17 +54,6 @@ private: typedef Benchmark INHERITED; }; -static int gDivs9[2] = { 25, 75, }; -DEF_BENCH(return new DrawLatticeBench(gDivs9, 2, gDivs9, 2, SkISize::Make(100, 100), - SkRect::MakeWH(250.0f, 250.0f), "Src100_Dst250_Rects9");) -DEF_BENCH(return new DrawLatticeBench(gDivs9, 2, gDivs9, 2, SkISize::Make(100, 100), - SkRect::MakeWH(500.0f, 500.0f), "Src100_Dst500_Rects9");) -DEF_BENCH(return new DrawLatticeBench(gDivs9, 2, gDivs9, 2, SkISize::Make(100, 100), - SkRect::MakeWH(1000.0f, 1000.0f), "Src100_Dst1000_Rects9");) -static int gDivs15[4] = { 15, 45, 55, 85, }; -DEF_BENCH(return new DrawLatticeBench(gDivs15, 4, gDivs15, 4, SkISize::Make(100, 100), - SkRect::MakeWH(250.0f, 250.0f), "Src100_Dst250_Rects15");) -DEF_BENCH(return new DrawLatticeBench(gDivs15, 4, gDivs15, 4, SkISize::Make(100, 100), - SkRect::MakeWH(500.0f, 500.0f), "Src100_Dst500_Rects15");) -DEF_BENCH(return new DrawLatticeBench(gDivs15, 4, gDivs15, 4, SkISize::Make(100, 100), - SkRect::MakeWH(1000.0f, 1000.0f), "Src100_Dst1000_Rects15");) +static int gDivs[2] = { 250, 750, }; +DEF_BENCH(return new DrawLatticeBench(gDivs, 2, gDivs, 2, SkISize::Make(1000, 1000), + SkRect::MakeWH(4000.0f, 4000.0f), "StandardNine");) |