diff options
author | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-12-03 18:17:16 +0000 |
---|---|---|
committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-12-03 18:17:16 +0000 |
commit | 3361471a3504ecd0351ff70f4c42d8d6fee963d4 (patch) | |
tree | 1886e770069303c70c588c396b2d9c19343e3adc /bench/ChecksumBench.cpp | |
parent | e3bb3bce3e9c1f3bc8ee779b1b3383c18e560bce (diff) |
Simplify benchmark internal API.
I'm not quite sure why I wrote such a convoluted API with setLoops()/getLoops().
This replaces it with a loops argument passed to onDraw().
This CL is largely mechanical translation from the old API to the new one.
MathBench used this->getLoops() outside onDraw(), which seems incorrect. I
fixed it.
BUG=
R=djsollen@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/99893003
git-svn-id: http://skia.googlecode.com/svn/trunk@12466 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'bench/ChecksumBench.cpp')
-rw-r--r-- | bench/ChecksumBench.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/bench/ChecksumBench.cpp b/bench/ChecksumBench.cpp index d57ede370b..898c411641 100644 --- a/bench/ChecksumBench.cpp +++ b/bench/ChecksumBench.cpp @@ -51,16 +51,16 @@ protected: } } - virtual void onDraw(SkCanvas*) { + virtual void onDraw(const int loops, SkCanvas*) { switch (fType) { case kChecksum_ChecksumType: { - for (int i = 0; i < this->getLoops(); i++) { + for (int i = 0; i < loops; i++) { volatile uint32_t result = SkChecksum::Compute(fData, sizeof(fData)); sk_ignore_unused_variable(result); } } break; case kMD5_ChecksumType: { - for (int i = 0; i < this->getLoops(); i++) { + for (int i = 0; i < loops; i++) { SkMD5 md5; md5.update(reinterpret_cast<uint8_t*>(fData), sizeof(fData)); SkMD5::Digest digest; @@ -68,7 +68,7 @@ protected: } } break; case kSHA1_ChecksumType: { - for (int i = 0; i < this->getLoops(); i++) { + for (int i = 0; i < loops; i++) { SkSHA1 sha1; sha1.update(reinterpret_cast<uint8_t*>(fData), sizeof(fData)); SkSHA1::Digest digest; @@ -76,7 +76,7 @@ protected: } } break; case kMurmur3_ChecksumType: { - for (int i = 0; i < this->getLoops(); i++) { + for (int i = 0; i < loops; i++) { volatile uint32_t result = SkChecksum::Murmur3(fData, sizeof(fData)); sk_ignore_unused_variable(result); } |