diff options
| author |  commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-04-15 15:48:36 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-04-15 15:48:36 +0000 |
| commit | 73cb15351f33459e0c861a96135c634dec77ef9d (patch) | |
| tree | cf521a48286c5cd88354056e65a933cc63f8fbe1 /bench/BlurRoundRectBench.cpp | |
| parent | beb8b3a4da83ce30e313e72ae0e444870acecb7e (diff) | |
Make sure SkDrawLooper objects can only be allocated on the heap.
Make constructors of SkLayerDrawLooper and SkBlurDrawLooper non-public.
Remove addLayer* methods from SkLayerDrawLooper. SkLayerDrawLooper::Builder is
used to create new objects.
Provide factory method for creating SkBlurDrawLooper.
BUG=2141
R=scroggo@google.com, reed@google.com, djsollen@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/232913003
git-svn-id: http://skia.googlecode.com/svn/trunk@14200 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'bench/BlurRoundRectBench.cpp')
| -rw-r--r-- | bench/BlurRoundRectBench.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/bench/BlurRoundRectBench.cpp b/bench/BlurRoundRectBench.cpp index 29c0080594..a3d0ba9fd9 100644 --- a/bench/BlurRoundRectBench.cpp +++ b/bench/BlurRoundRectBench.cpp @@ -40,7 +40,7 @@ public: } virtual void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE { - SkLayerDrawLooper* looper = new SkLayerDrawLooper; + SkLayerDrawLooper::Builder looperBuilder; { SkLayerDrawLooper::LayerInfo info; info.fPaintBits = SkLayerDrawLooper::kMaskFilter_Bit @@ -48,7 +48,7 @@ public: info.fColorMode = SkXfermode::kSrc_Mode; info.fOffset = SkPoint::Make(SkIntToScalar(-1), SkIntToScalar(0)); info.fPostTranslate = false; - SkPaint* paint = looper->addLayerOnTop(info); + SkPaint* paint = looperBuilder.addLayerOnTop(info); SkMaskFilter* maskFilter = SkBlurMaskFilter::Create( SkBlurMaskFilter::kNormal_BlurStyle, SkBlurMask::ConvertRadiusToSigma(SK_ScalarHalf), @@ -61,13 +61,13 @@ public: } { SkLayerDrawLooper::LayerInfo info; - looper->addLayerOnTop(info); + looperBuilder.addLayerOnTop(info); } SkPaint dullPaint; dullPaint.setAntiAlias(true); SkPaint loopedPaint; - loopedPaint.setLooper(looper)->unref(); + loopedPaint.setLooper(looperBuilder.detachLooper())->unref(); loopedPaint.setAntiAlias(true); loopedPaint.setColor(SK_ColorCYAN); |