diff options
author | mtklein <mtklein@chromium.org> | 2015-07-13 06:18:39 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-07-13 06:18:39 -0700 |
commit | f059900f75639f1b1a03f2c25333ef9aa22d58b8 (patch) | |
tree | f7c27d37b1c84ac3f7e4b15af4eb513be84a922a /bench/BitmapBench.cpp | |
parent | 4598fc3c123cd8af1dac5596f955a375186a31f3 (diff) |
Fix up -Winconsistent-missing-override
(and a couple presubmit fixes)
This allows us to turn back on -Werror for LLVM coverage builds,
and more generally supports building with Clang 3.7.
No public API changes.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1232463006
Diffstat (limited to 'bench/BitmapBench.cpp')
-rw-r--r-- | bench/BitmapBench.cpp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/bench/BitmapBench.cpp b/bench/BitmapBench.cpp index 6220247c8d..718f7ac86f 100644 --- a/bench/BitmapBench.cpp +++ b/bench/BitmapBench.cpp @@ -93,7 +93,7 @@ public: {} protected: - virtual const char* onGetName() { + const char* onGetName() override { fName.set("bitmap"); fName.appendf("_%s%s", sk_tool_utils::colortype_name(fColorType), kOpaque_SkAlphaType == fAlphaType ? "" : "_A"); @@ -110,7 +110,7 @@ protected: return fName.c_str(); } - virtual void onPreDraw() { + void onPreDraw() override { SkBitmap bm; if (kIndex_8_SkColorType == fColorType) { @@ -120,7 +120,7 @@ protected: } bm.eraseColor(kOpaque_SkAlphaType == fAlphaType ? SK_ColorBLACK : 0); - onDrawIntoBitmap(bm); + this->onDrawIntoBitmap(bm); if (kIndex_8_SkColorType == fColorType) { convertToIndex666(bm, &fBitmap, fAlphaType); @@ -131,7 +131,7 @@ protected: fBitmap.setIsVolatile(fIsVolatile); } - virtual void onDraw(const int loops, SkCanvas* canvas) { + void onDraw(const int loops, SkCanvas* canvas) override { if (fDoScale) { canvas->scale(.99f, .99f); } @@ -156,7 +156,7 @@ protected: } } - virtual void onDrawIntoBitmap(const SkBitmap& bm) { + virtual void onDrawIntoBitmap(const SkBitmap& bm) { const int w = bm.width(); const int h = bm.height(); @@ -208,7 +208,7 @@ public: } protected: - virtual const char* onGetName() { + const char* onGetName() override { fFullName.set(INHERITED::onGetName()); if (fFlags & kScale_Flag) { fFullName.append("_scale"); @@ -225,7 +225,7 @@ protected: return fFullName.c_str(); } - virtual void onDraw(const int loops, SkCanvas* canvas) { + void onDraw(const int loops, SkCanvas* canvas) override { SkISize dim = canvas->getDeviceSize(); if (fFlags & kScale_Flag) { const SkScalar x = SkIntToScalar(dim.fWidth) / 2; @@ -287,7 +287,7 @@ public: } protected: - virtual const char* onGetName() { + const char* onGetName() override { fFullName.set(INHERITED::onGetName()); if (fSourceAlpha == kOpaque_SourceAlpha) { |