aboutsummaryrefslogtreecommitdiffhomepage
path: root/CONTRIBUTING
diff options
context:
space:
mode:
authorGravatar commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>2014-05-27 15:55:35 +0000
committerGravatar commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>2014-05-27 15:55:35 +0000
commit64f6d154511fc840e9a2db1f17699fd5799f7917 (patch)
treec7f62c88a589d19c840652c250b175feb6603b75 /CONTRIBUTING
parente8765c46540041240dd9bc3eedaeb6956ddc4ff1 (diff)
Use SkAtomics_sync on Android
Every doc I've found about using Android's atomics says, "stop". "* A handful of basic atomic operations. The appropriate pthread * functions should be used instead of these whenever possible." "... we recommend stopping from using these functions entirely. Very fortunately, GCC provides handy intrinsics functions that work with very reasonable performance and always provide a full barrier." As far as I can tell, there's no code generation change here: both the __sync atomics and the android_ atomics use full memory barriers. (And now with this all unified, it'll be easier to get the real wins by switching everything to __atomic atomics, which are like __sync atomics but allow control over memory barriers.) BUG=skia: R=bungeman@google.com, djsollen@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/305593002 git-svn-id: http://skia.googlecode.com/svn/trunk@14896 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'CONTRIBUTING')
0 files changed, 0 insertions, 0 deletions