aboutsummaryrefslogtreecommitdiffhomepage
path: root/BUILD.gn
diff options
context:
space:
mode:
authorGravatar Mike Klein <mtklein@chromium.org>2017-12-14 15:33:47 -0500
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2017-12-14 21:00:57 +0000
commitdbd43481f1da3c9c87f5d913660f216ec531870a (patch)
tree1cd52f4d883d5911ebfac947ee701d26006fd198 /BUILD.gn
parent5cdf667530ec1652f1d6eb52070ca64cb1839d90 (diff)
Don't pass a stack address as a pipeline context pointer.
We call isNumericalTransferFn() both to test if an SkColorSpace is a 7-parameter numerical transfer function, and to get those parameters if so. They're passed to the stage functions that apply that transfer function via a context pointer. We can't use &srcFn as this pointer, as it's on the stack, and won't be alive by the time we get around to running the pipeline. Instead, copy it to the SkArenaAlloc we thread through just for this purpose. This would be a beginner's mistake, except that I wrote the API myself... Bug: chromium:794406 Change-Id: I9f9581f07a14ab501762f050e2c26f2e55a0c253 Reviewed-on: https://skia-review.googlesource.com/85340 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'BUILD.gn')
0 files changed, 0 insertions, 0 deletions