diff options
| author |  Ben Wagner <benjaminwagner@google.com> | 2017-10-18 18:09:37 +0000 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-10-18 18:09:47 +0000 |
| commit | 021e5c70160c9682e8d8ab6e2c36a3cb3f57604a (patch) | |
| tree | d21021d44fa49985d169bd7906c47f2bbe6a27fd /BUILD.gn | |
| parent | 7c4ce9b94b9dd7983d554874f35827cc608aa46c (diff) | |
Revert "Add an Option for orientation on JPEG encodes"
This reverts commit 5411a60e0d7370a5d47b5049de845a06fe52e98b.
Reason for revert: ASAN and Coverage failing: https://chromium-swarm.appspot.com/task?id=394978f3b7d44610
Flutter_Android failing.
Original change's description:
> Add an Option for orientation on JPEG encodes
>
> Move Origin to its own header so that SkPixmap and SkJpegEncoder need
> not depend on SkCodec.
>
> Add libexif, which is already used by Android, and use it to write the
> orientation. Write a makefile based on the Android.bp in Android, minus
> warnings. (libexif has an LGPL license.)
>
> Add a test that verifies all the orientations work.
>
> Optionally enable writing the orientation (and therefore including
> libexif). Chromium does not currently need it, and Android does not
> expose an API that would allow using it. Disable on Windows, where we
> still have build errors to fix.
>
> Bug: skia:7138
> Change-Id: Iaeff44c36aebe0e639666979dc00e1b7594bbeb1
> Reviewed-on: https://skia-review.googlesource.com/60721
> Commit-Queue: Leon Scroggins <scroggo@google.com>
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Mike Reed <reed@google.com>
TBR=mtklein@chromium.org,mtklein@google.com,scroggo@google.com,reed@google.com
Change-Id: I05b7ae8d1c5bbd1de1642d9ef024943500256273
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7138
Reviewed-on: https://skia-review.googlesource.com/61620
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Diffstat (limited to 'BUILD.gn')
| -rw-r--r-- | BUILD.gn | 6 |
1 files changed, 0 insertions, 6 deletions
@@ -23,7 +23,6 @@ declare_args() { skia_use_freetype = is_android || is_fuchsia || is_linux skia_use_gdi = false skia_use_icu = !is_fuchsia && !is_ios && !is_win # TODO: Windows - skia_use_libexif = !is_win # TODO: Windows skia_use_libjpeg_turbo = true skia_use_libpng = true skia_use_libwebp = !is_fuchsia @@ -611,11 +610,6 @@ optional("jpeg") { "src/images/SkJPEGWriteUtility.cpp", "src/images/SkJpegEncoder.cpp", ] - - if (skia_use_libexif) { - public_defines += [ "SK_HAS_EXIF_LIBRARY" ] - deps += [ "//third_party/libexif" ] - } } optional("pdf") { |