diff options
| author |  mtklein <mtklein@chromium.org> | 2014-06-03 15:59:23 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-06-03 15:59:23 -0700 |
| commit | e696a5962a67c540eaa5d79c860d85a5c9a29a45 (patch) | |
| tree | 8c13d144cedcb8c3715385c3fcf1f51c52d0866c | |
| parent | 06fdc6937df52942226a0a5e7bba169c27006ef1 (diff) | |
Disable PDF in dm for tonight. It's crashy.
BUG=skia:2598
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/317533003
| -rw-r--r-- | dm/DMPDFTask.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/dm/DMPDFTask.cpp b/dm/DMPDFTask.cpp index 270f4b4fef..e50e9ecb70 100644 --- a/dm/DMPDFTask.cpp +++ b/dm/DMPDFTask.cpp @@ -13,7 +13,11 @@ #include "SkCommandLineFlags.h" #include "SkDocument.h" -DEFINE_bool(pdf, true, "PDF backend master switch."); +// The PDF backend is not threadsafe. If you run dm with --pdf repeatedly, you +// will quickly find yourself crashed. (while catchsegv out/Release/dm;; end). +// +// TODO(mtklein): re-enable by default, maybe moving to its own single thread. +DEFINE_bool(pdf, false, "PDF backend master switch."); namespace DM { |