Force SkPath::getConvexity() cache for thread safety.

I happened to stumble on this in a run of TSAN:
    https://luci-milo.appspot.com/swarming/task/30fffe9497dc6310/steps/dm/0/stdout

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300003003

Review-Url: https://codereview.chromium.org/2300003003

2 files changed, 5 insertions, 1 deletions

diff --git a/src/core/SkLiteDL.cpp b/src/core/SkLiteDL.cpp
index fee6de385c..b88f7bc62c 100644
--- a/src/core/SkLiteDL.cpp
+++ b/src/core/SkLiteDL.cpp
@@ -43,7 +43,10 @@ static D* pod(T* op, size_t offset = 0) {
 
 // Pre-cache lazy non-threadsafe fields on SkPath and/or SkMatrix.
 static void make_threadsafe(SkPath* path, SkMatrix* matrix) {
-    if (path)   { path->updateBoundsCache(); }
+    if (path) {
+        path->updateBoundsCache();
+        (void)path->getConvexity();
+    }
     if (matrix) { (void)matrix->getType(); }
 }
 
diff --git a/src/core/SkRecords.cpp b/src/core/SkRecords.cpp
index 81dd92f9ef..555f992369 100644
--- a/src/core/SkRecords.cpp
+++ b/src/core/SkRecords.cpp
@@ -11,6 +11,7 @@
 namespace SkRecords {
     PreCachedPath::PreCachedPath(const SkPath& path) : SkPath(path) {
         this->updateBoundsCache();
+        (void)this->getConvexity();
 #if 0  // Disabled to see if we ever really race on this.  It costs time, chromium:496982.
         SkPathPriv::FirstDirection junk;
         (void)SkPathPriv::CheapComputeFirstDirection(*this, &junk);