diff options
| author |  mtklein <mtklein@chromium.org> | 2014-10-13 12:53:27 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-10-13 12:53:28 -0700 |
| commit | cad5d3e264535c919b80e1e2a85407307961f221 (patch) | |
| tree | bbd7954560bfbda9749e7cf2ba2903980f0e741f | |
| parent | c09e2af17fab03d3d36c20e5201a560c3e4c233e (diff) | |
No threadsafe statics.
Chrome disables these for speed and code size, so we need
to disable them to make sure our code is safe when used
this way.
int foo() {
static int32_t atomic_thing;
return sk_atomic_inc(&atomic_thing);
}
is not safe in Chrome. Making the static global is:
static int32_t atomic_thing;
int foo() {
return sk_atomic_inc(&atomic_thing);
}
BUG=skia:
Review URL: https://codereview.chromium.org/654663002
| -rw-r--r-- | gyp/common_conditions.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi index d9c048771e..e584cbc960 100644 --- a/gyp/common_conditions.gypi +++ b/gyp/common_conditions.gypi @@ -202,6 +202,7 @@ ], 'cflags_cc': [ '-fno-rtti', + '-fno-threadsafe-statics', # Chrome disables this, so for safety we should too. '-Wnon-virtual-dtor', '-Wno-invalid-offsetof', # GCC <4.6 is old-school strict about what is POD. ], |