aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar robertphillips <robertphillips@google.com>2016-04-04 05:28:03 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2016-04-04 05:28:03 -0700
commitaee62f563968437bff0ffdc5aa6185781a81bfd3 (patch)
treef8ec5dcb10f9cf4406c3ab7f1081def7e7b62415
parent43c2ad4e8f9ed84f46caa57e0b471f7393f1280a (diff)
Revert of Switch SkDownSampleImageFilter over to new onFilterImage interface (patchset #6 id:100001 of https://codereview.chromium.org/1851583002/ )
Reason for revert: changing images on bots Original issue's description: > Switch SkDownSampleImageFilter over to new onFilterImage interface > > This will slightly change the testimagefilters GM images > > TBR=reed@google.com > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1851583002 > > Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5 > > Committed: https://skia.googlesource.com/skia/+/33550dab45516bbcfa5ab908c5857fb382535c44 TBR=senorblanco@chromium.org,reed@google.com,senorblanco@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1859533002
-rw-r--r--include/effects/SkTestImageFilters.h5
-rwxr-xr-xsrc/effects/SkTestImageFilters.cpp79
2 files changed, 41 insertions, 43 deletions
diff --git a/include/effects/SkTestImageFilters.h b/include/effects/SkTestImageFilters.h
index 943bb53356..2b3ca84da8 100644
--- a/include/effects/SkTestImageFilters.h
+++ b/include/effects/SkTestImageFilters.h
@@ -30,9 +30,8 @@ public:
protected:
void flatten(SkWriteBuffer&) const override;
-
- sk_sp<SkSpecialImage> onFilterImage(SkSpecialImage* source, const Context&,
- SkIPoint* offset) const override;
+ bool onFilterImageDeprecated(Proxy*, const SkBitmap& src, const Context&, SkBitmap* result,
+ SkIPoint* loc) const override;
private:
SkDownSampleImageFilter(SkScalar scale, SkImageFilter* input)
diff --git a/src/effects/SkTestImageFilters.cpp b/src/effects/SkTestImageFilters.cpp
index f1ac33bcd7..e9ec7c19ce 100755
--- a/src/effects/SkTestImageFilters.cpp
+++ b/src/effects/SkTestImageFilters.cpp
@@ -7,22 +7,36 @@
#include "SkTestImageFilters.h"
#include "SkCanvas.h"
+#include "SkDevice.h"
#include "SkReadBuffer.h"
-#include "SkSpecialImage.h"
-#include "SkSpecialSurface.h"
#include "SkWriteBuffer.h"
+// Simple helper canvas that "takes ownership" of the provided device, so that
+// when this canvas goes out of scope, so will its device. Could be replaced
+// with the following:
+//
+// SkCanvas canvas(device);
+// SkAutoTUnref<SkBaseDevice> aur(device);
+//
+class OwnDeviceCanvas : public SkCanvas {
+public:
+ OwnDeviceCanvas(SkBaseDevice* device) : SkCanvas(device) {
+ SkSafeUnref(device);
+ }
+};
+
///////////////////////////////////////////////////////////////////////////////
-sk_sp<SkSpecialImage> SkDownSampleImageFilter::onFilterImage(SkSpecialImage* source,
- const Context& ctx,
- SkIPoint* offset) const {
- if (fScale > SK_Scalar1 || fScale <= 0) {
- return nullptr;
+bool SkDownSampleImageFilter::onFilterImageDeprecated(Proxy* proxy, const SkBitmap& src,
+ const Context&,
+ SkBitmap* result, SkIPoint*) const {
+ SkScalar scale = fScale;
+ if (scale > SK_Scalar1 || scale <= 0) {
+ return false;
}
- int dstW = SkScalarRoundToInt(source->width() * fScale);
- int dstH = SkScalarRoundToInt(source->height() * fScale);
+ int dstW = SkScalarRoundToInt(src.width() * scale);
+ int dstH = SkScalarRoundToInt(src.height() * scale);
if (dstW < 1) {
dstW = 1;
}
@@ -30,50 +44,35 @@ sk_sp<SkSpecialImage> SkDownSampleImageFilter::onFilterImage(SkSpecialImage* sou
dstH = 1;
}
- sk_sp<SkSpecialImage> tmp;
+ SkBitmap tmp;
// downsample
{
- const SkImageInfo info = SkImageInfo::MakeN32Premul(dstW, dstH);
-
- sk_sp<SkSpecialSurface> surf(source->makeSurface(info));
- if (!surf) {
- return nullptr;
+ SkBaseDevice* dev = proxy->createDevice(dstW, dstH);
+ if (nullptr == dev) {
+ return false;
}
-
- SkCanvas* canvas = surf->getCanvas();
- SkASSERT(canvas);
-
+ OwnDeviceCanvas canvas(dev);
SkPaint paint;
- paint.setXfermodeMode(SkXfermode::kSrcOver_Mode);
- paint.setFilterQuality(kLow_SkFilterQuality);
-
- canvas->scale(fScale, fScale);
- source->draw(canvas, 0, 0, &paint);
- tmp = surf->makeImageSnapshot();
+ paint.setFilterQuality(kLow_SkFilterQuality);
+ canvas.scale(scale, scale);
+ canvas.drawBitmap(src, 0, 0, &paint);
+ tmp = dev->accessBitmap(false);
}
// upscale
{
- const SkImageInfo info = SkImageInfo::MakeN32Premul(source->width(), source->height());
-
- sk_sp<SkSpecialSurface> surf(source->makeSurface(info));
- if (!surf) {
- return nullptr;
+ SkBaseDevice* dev = proxy->createDevice(src.width(), src.height());
+ if (nullptr == dev) {
+ return false;
}
+ OwnDeviceCanvas canvas(dev);
- SkCanvas* canvas = surf->getCanvas();
- SkASSERT(canvas);
-
- SkPaint paint;
- paint.setXfermodeMode(SkXfermode::kSrcOver_Mode);
-
- canvas->scale(SkScalarInvert(fScale), SkScalarInvert(fScale));
- tmp->draw(canvas, 0, 0, &paint);
-
- return surf->makeImageSnapshot();
+ canvas.drawBitmapRect(tmp, SkRect::MakeIWH(src.width(), src.height()), nullptr);
+ *result = dev->accessBitmap(false);
}
+ return true;
}
sk_sp<SkFlattenable> SkDownSampleImageFilter::CreateProc(SkReadBuffer& buffer) {