diff options
| author |  bungeman <bungeman@google.com> | 2014-12-05 07:14:53 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-12-05 07:14:53 -0800 |
| commit | a9bf1aadcd7db586f809aa6fd9a1af0040e09016 (patch) | |
| tree | 7b4e50d9a2f673c89bc66304c563b88700458a47 | |
| parent | 0be41a06d75f5266cc7e25f19d369c480c29f28a (diff) | |
Tolerate unstarted builds in rebaseline server.
Currently server.py --rietveld-issue will crash if there are any
unstarted trybots on the latest patch. Instead of crashing, warn
that the bot hasn't started yet.
Review URL: https://codereview.chromium.org/758793003
| -rwxr-xr-x | gm/rebaseline_server/download_actuals.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/gm/rebaseline_server/download_actuals.py b/gm/rebaseline_server/download_actuals.py index 437b66328d..ae16770c49 100755 --- a/gm/rebaseline_server/download_actuals.py +++ b/gm/rebaseline_server/download_actuals.py @@ -197,6 +197,9 @@ class RietveldIssueActuals(object): logging.info('Fetching issue %s patch %s try %s...' % (self._issue, patchset, try_builder)) build_url = try_job_result.get('url', '<bad url>') + if build_url is None: + logging.warning('Builder %s has not started.' % (try_builder,)) + continue gm_upload_output_url = build_url + urllib2.quote(upload_gm_step_url) logging.info('Fetching %s ...' % (gm_upload_output_url,)) |