aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>2014-04-11 19:54:16 +0000
committerGravatar commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>2014-04-11 19:54:16 +0000
commita1bf8be772f2cb626c95e26f56f0fa78d33f65d5 (patch)
treecd9e41c6b6f7114322beb61c4a50d9137f903000
parentbd4d7eae7297ed6ff2633cdac32771001d11174a (diff)
Further adjust bench expectations calculation.
BUG=skia:2225 TBR=robertphillips@google.com NOTRY=true Author: bensong@google.com Review URL: https://codereview.chromium.org/235693003 git-svn-id: http://skia.googlecode.com/svn/trunk@14165 2bbb7eff-a529-9590-31e7-b0007b416f81
-rw-r--r--bench/gen_bench_expectations.py8
1 files changed, 5 insertions, 3 deletions
diff --git a/bench/gen_bench_expectations.py b/bench/gen_bench_expectations.py
index 4212c0e05b..75035ffda7 100644
--- a/bench/gen_bench_expectations.py
+++ b/bench/gen_bench_expectations.py
@@ -12,8 +12,10 @@ import re
import sys
# Parameters for calculating bench ranges.
-RANGE_RATIO = 1.0 # Ratio of range for upper and lower bounds.
+RANGE_RATIO_UPPER = 1.0 # Ratio of range for upper bounds.
+RANGE_RATIO_LOWER = 1.5 # Ratio of range for lower bounds.
ERR_RATIO = 0.05 # Further widens the range by the ratio of average value.
+ERR_ABS = 0.5 # Adds an absolute error margin to cope with very small benches.
# List of bench configs to monitor. Ignore all other configs.
CONFIGS_TO_INCLUDE = ['simple_viewport_1000x1000',
@@ -37,8 +39,8 @@ def compute_ranges(benches):
diff = maximum - minimum
avg = sum(benches) / len(benches)
- return [minimum - diff * RANGE_RATIO - avg * ERR_RATIO,
- maximum + diff * RANGE_RATIO + avg * ERR_RATIO]
+ return [minimum - diff * RANGE_RATIO_LOWER - avg * ERR_RATIO - ERR_ABS,
+ maximum + diff * RANGE_RATIO_UPPER + avg * ERR_RATIO + ERR_ABS]
def create_expectations_dict(revision_data_points):