aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar egdaniel <egdaniel@google.com>2015-03-20 07:03:52 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2015-03-20 07:03:52 -0700
commit9a0f629973ee97ea10f5e3c36a802eca4270d7e0 (patch)
treedbde5678c7975d32aa470b079bf99e6c7d43cb5e
parentca75ea871e40cc4ebd19bfa26a096bec19fd464e (diff)
Only use 256x256 tiles on hd2000 nanobench bots
Initial experiments did show that the 256 tile size fixed the hd2000 win7 nanobot failures. However it did not have any effect on other bots, so this change is to move back to the larger tile size on all bots expect for the hd2000. BUG=skia: Review URL: https://codereview.chromium.org/1022083002
-rw-r--r--bench/SKPBench.cpp4
-rw-r--r--tools/nanobench_flags.json4
-rwxr-xr-xtools/nanobench_flags.py4
3 files changed, 10 insertions, 2 deletions
diff --git a/bench/SKPBench.cpp b/bench/SKPBench.cpp
index 8139eda98d..3f521799fa 100644
--- a/bench/SKPBench.cpp
+++ b/bench/SKPBench.cpp
@@ -10,8 +10,8 @@
#include "SkMultiPictureDraw.h"
#include "SkSurface.h"
-DEFINE_int32(benchTileW, 256, "Tile width used for SKP playback.");
-DEFINE_int32(benchTileH, 256, "Tile height used for SKP playback.");
+DEFINE_int32(benchTileW, 1600, "Tile width used for SKP playback.");
+DEFINE_int32(benchTileH, 512, "Tile height used for SKP playback.");
SKPBench::SKPBench(const char* name, const SkPicture* pic, const SkIRect& clip, SkScalar scale,
bool useMultiPictureDraw)
diff --git a/tools/nanobench_flags.json b/tools/nanobench_flags.json
index c98c2e1502..8a50d25545 100644
--- a/tools/nanobench_flags.json
+++ b/tools/nanobench_flags.json
@@ -85,6 +85,10 @@
"hwui",
"msaa16",
"nvprmsaa16",
+ "--benchTileW",
+ "256",
+ "--benchTileH",
+ "256",
"--match",
"~gradient",
"~etc1bitmap"
diff --git a/tools/nanobench_flags.py b/tools/nanobench_flags.py
index 81cd8cebe0..cbd5c84796 100755
--- a/tools/nanobench_flags.py
+++ b/tools/nanobench_flags.py
@@ -45,6 +45,10 @@ def get_args(bot):
elif 'Valgrind_CPU' in bot:
args.append('--nogpu')
+ if 'HD2000' in bot:
+ args.extend(['--benchTileW', '256'])
+ args.extend(['--benchTileH', '256'])
+
match = []
if 'Android' in bot:
# Segfaults when run as GPU bench. Very large texture?