diff options
author | 2014-09-12 17:07:34 -0700 | |
---|---|---|
committer | 2014-09-12 17:07:34 -0700 | |
commit | 94c415170b6f62fa80b598fe30bf2f99f0aecf6a (patch) | |
tree | 3bd4a7eddc8ddfc54d8d04231456f527c548d7e5 | |
parent | 86e01df8d1d8848044c3fcc31c1a2008b70fe08c (diff) |
Revert of Add a test that uses C++11 features as a compiler canary. (patchset #2 id:20001 of https://codereview.chromium.org/568913002/)
Reason for revert:
nope, nacl and ubuntu local bots (at least) broken
Original issue's description:
> Add a test that uses C++11 features as a compiler canary.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/86e01df8d1d8848044c3fcc31c1a2008b70fe08c
R=bungeman@google.com, mtklein@chromium.org
TBR=bungeman@google.com, mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/565213008
-rw-r--r-- | gyp/common_conditions.gypi | 11 | ||||
-rw-r--r-- | gyp/tests.gypi | 1 | ||||
-rw-r--r-- | tests/Cpp11Test.cpp | 14 |
3 files changed, 5 insertions, 21 deletions
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi index 92095eaf1a..338dbc1f87 100644 --- a/gyp/common_conditions.gypi +++ b/gyp/common_conditions.gypi @@ -202,7 +202,6 @@ '-Wno-unused-parameter', ], 'cflags_cc': [ - '-std=c++11', '-fno-rtti', '-Wnon-virtual-dtor', '-Wno-invalid-offsetof', # GCC <4.6 is old-school strict about what is POD. @@ -454,6 +453,8 @@ }], [ 'skia_clang_build', { 'cflags_cc': [ + # Build in C++11 mode to make sure we'll have an easy time switching. + '-std=c++11', '-Wno-unknown-warning-option', # Allows unknown warnings. '-Wno-deprecated', # From Qt, via debugger (older Clang). '-Wno-deprecated-register', # From Qt, via debugger (newer Clang). @@ -503,10 +504,9 @@ 'MACOSX_DEPLOYMENT_TARGET': '<(skia_osx_deployment_target)', }], ], - 'CLANG_CXX_LANGUAGE_STANDARD': 'c++0x', # -std=c++11 - 'GCC_ENABLE_SUPPLEMENTAL_SSE3_INSTRUCTIONS': 'YES', # -mssse3 - 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', # -fvisibility=hidden - 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'NO', # -fvisibility-inlines-hidden + 'GCC_ENABLE_SUPPLEMENTAL_SSE3_INSTRUCTIONS': 'YES', # -mssse3 + 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', # -fvisibility=hidden + 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'NO', # -fvisibility-inlines-hidden 'WARNING_CFLAGS': [ '-Wall', '-Wextra', @@ -546,7 +546,6 @@ }, 'xcode_settings': { 'ARCHS': ['armv7'], - 'CLANG_CXX_LANGUAGE_STANDARD': 'c++0x', # -std=c++11 'CODE_SIGNING_REQUIRED': 'NO', 'CODE_SIGN_IDENTITY[sdk=iphoneos*]': '', 'IPHONEOS_DEPLOYMENT_TARGET': '<(ios_sdk_version)', diff --git a/gyp/tests.gypi b/gyp/tests.gypi index e1dde578af..cf78e41f63 100644 --- a/gyp/tests.gypi +++ b/gyp/tests.gypi @@ -72,7 +72,6 @@ '../tests/ColorFilterTest.cpp', '../tests/ColorPrivTest.cpp', '../tests/ColorTest.cpp', - '../tests/Cpp11Test.cpp', '../tests/DashPathEffectTest.cpp', '../tests/DataRefTest.cpp', '../tests/DeferredCanvasTest.cpp', diff --git a/tests/Cpp11Test.cpp b/tests/Cpp11Test.cpp deleted file mode 100644 index 627c4d4f69..0000000000 --- a/tests/Cpp11Test.cpp +++ /dev/null @@ -1,14 +0,0 @@ -/* - * Copyright 2014 Google Inc. - * - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ - -#include "Test.h" - -DEF_TEST(Cpp11, r) { - auto square = [](int x){ return x*x; }; - - REPORTER_ASSERT(r, square(4) == 16); -} |