aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar reed <reed@google.com>2016-02-15 08:27:14 -0800
committerGravatar Commit bot <commit-bot@chromium.org>2016-02-15 08:27:14 -0800
commit8681e60b2ccd4cea37128a129f1adf6a6d59bb7d (patch)
tree1179977e2f2d896b9b09ce6a785bf409da986cc8
parenta34be68a7eff0ae475b194f8a29975460cf3e456 (diff)
make SkComposeShader.h private
-rw-r--r--gm/composeshader.cpp9
-rw-r--r--gyp/core.gypi1
-rw-r--r--samplecode/PerlinPatch.cpp3
-rw-r--r--samplecode/SampleAll.cpp3
-rw-r--r--samplecode/SampleArc.cpp1
-rw-r--r--samplecode/SampleShaders.cpp5
-rw-r--r--src/core/SkComposeShader.cpp2
-rw-r--r--src/core/SkComposeShader.h (renamed from include/core/SkComposeShader.h)0
8 files changed, 8 insertions, 16 deletions
diff --git a/gm/composeshader.cpp b/gm/composeshader.cpp
index d482bc9420..2f3d99d364 100644
--- a/gm/composeshader.cpp
+++ b/gm/composeshader.cpp
@@ -9,7 +9,6 @@
#include "SkBitmapProcShader.h"
#include "SkCanvas.h"
-#include "SkComposeShader.h"
#include "SkGradientShader.h"
#include "SkGraphics.h"
#include "SkShader.h"
@@ -36,7 +35,7 @@ static SkShader* make_shader(SkXfermode::Mode mode) {
SkAutoTUnref<SkXfermode> xfer(SkXfermode::Create(mode));
- return new SkComposeShader(shaderA, shaderB, xfer);
+ return SkShader::CreateComposeShader(shaderA, shaderB, xfer);
}
class ComposeShaderGM : public skiagm::GM {
@@ -194,11 +193,11 @@ protected:
SkAutoTUnref<SkXfermode> xfer(SkXfermode::Create(SkXfermode::kDstOver_Mode));
// gradient should appear over color bitmap
- SkAutoTUnref<SkShader> shader0(new SkComposeShader(fLinearGradientShader,
+ SkAutoTUnref<SkShader> shader0(SkShader::CreateComposeShader(fLinearGradientShader,
fColorBitmapShader,
xfer));
// gradient should appear over alpha8 bitmap colorized by the paint color
- SkAutoTUnref<SkShader> shader1(new SkComposeShader(fLinearGradientShader,
+ SkAutoTUnref<SkShader> shader1(SkShader::CreateComposeShader(fLinearGradientShader,
fAlpha8BitmapShader,
xfer));
@@ -226,7 +225,7 @@ protected:
}
private:
- /** This determines the length and width of the bitmaps used in the SkComposeShaders. Values
+ /** This determines the length and width of the bitmaps used in the ComposeShaders. Values
* above 20 may cause an SkASSERT to fail in SkSmallAllocator. However, larger values will
* work in a release build. You can change this parameter and then compile a release build
* to have this GM draw larger bitmaps for easier visual inspection.
diff --git a/gyp/core.gypi b/gyp/core.gypi
index 1700a05331..fe743c932e 100644
--- a/gyp/core.gypi
+++ b/gyp/core.gypi
@@ -332,7 +332,6 @@
'<(skia_include_path)/core/SkColor.h',
'<(skia_include_path)/core/SkColorFilter.h',
'<(skia_include_path)/core/SkColorPriv.h',
- '<(skia_include_path)/core/SkComposeShader.h',
'<(skia_include_path)/core/SkData.h',
'<(skia_include_path)/core/SkDeque.h',
'<(skia_include_path)/core/SkDevice.h',
diff --git a/samplecode/PerlinPatch.cpp b/samplecode/PerlinPatch.cpp
index 9bb95e5259..de4d451648 100644
--- a/samplecode/PerlinPatch.cpp
+++ b/samplecode/PerlinPatch.cpp
@@ -11,7 +11,6 @@
#include "SkGradientShader.h"
#include "SkPatchUtils.h"
#include "SkPerlinNoiseShader2/SkPerlinNoiseShader2.h"
-#include "SkComposeShader.h"
static void draw_control_points(SkCanvas* canvas, const SkPoint cubics[12]) {
//draw control points
@@ -148,7 +147,7 @@ protected:
SkScalar scaleFreq = 2.0;
fShader1 = SkPerlinNoiseShader2::CreateImprovedNoise(fXFreq/scaleFreq, fYFreq/scaleFreq, 4,
fSeed);
- fShaderCompose = new SkComposeShader(fShader0, fShader1);
+ fShaderCompose = SkShader::CreateComposeShader(fShader0, fShader1, nullptr);
paint.setShader(fShaderCompose);
canvas->drawPatch(fPts, nullptr, texCoords, xfer, paint);
diff --git a/samplecode/SampleAll.cpp b/samplecode/SampleAll.cpp
index ad3181f7cd..addca35fdc 100644
--- a/samplecode/SampleAll.cpp
+++ b/samplecode/SampleAll.cpp
@@ -28,7 +28,6 @@
#include "SkPictureRecorder.h"
#include "SkRegion.h"
#include "SkShader.h"
-#include "SkComposeShader.h"
#include "SkCornerPathEffect.h"
#include "SkPathMeasure.h"
#include "SkPicture.h"
@@ -511,7 +510,7 @@ protected:
SkShader* shaderB = SkGradientShader::CreateLinear(pts, colors2, nullptr,
2, SkShader::kClamp_TileMode);
SkXfermode* mode = SkXfermode::Create(SkXfermode::kDstIn_Mode);
- SkShader* result = new SkComposeShader(shaderA, shaderB, mode);
+ SkShader* result = SkShader::CreateComposeShader(shaderA, shaderB, mode);
shaderA->unref();
shaderB->unref();
mode->unref();
diff --git a/samplecode/SampleArc.cpp b/samplecode/SampleArc.cpp
index 834ba90a8f..3b5288dd08 100644
--- a/samplecode/SampleArc.cpp
+++ b/samplecode/SampleArc.cpp
@@ -15,7 +15,6 @@
#include "SkRegion.h"
#include "SkShader.h"
#include "SkUtils.h"
-#include "SkComposeShader.h"
#include "Sk1DPathEffect.h"
#include "SkCornerPathEffect.h"
#include "SkPathMeasure.h"
diff --git a/samplecode/SampleShaders.cpp b/samplecode/SampleShaders.cpp
index dd444ec34a..2c0a6ab749 100644
--- a/samplecode/SampleShaders.cpp
+++ b/samplecode/SampleShaders.cpp
@@ -16,7 +16,6 @@
#include "SkShader.h"
#include "SkUtils.h"
#include "SkXfermode.h"
-#include "SkComposeShader.h"
#include "SkColorPriv.h"
#include "SkColorFilter.h"
#include "SkTime.h"
@@ -38,7 +37,7 @@ static SkShader* make_bitmapfade(const SkBitmap& bm)
SkXfermode* mode = SkXfermode::Create(SkXfermode::kDstIn_Mode);
- SkShader* shader = new SkComposeShader(shaderB, shaderA, mode);
+ SkShader* shader = SkShader::CreateComposeShader(shaderB, shaderA, mode);
shaderA->unref();
shaderB->unref();
mode->unref();
@@ -71,7 +70,7 @@ public:
SkXfermode* mode = SkXfermode::Create(SkXfermode::kDstIn_Mode);
- fShader = new SkComposeShader(shaderA, shaderB, mode);
+ fShader = SkShader::CreateComposeShader(shaderA, shaderB, mode);
shaderA->unref();
shaderB->unref();
mode->unref();
diff --git a/src/core/SkComposeShader.cpp b/src/core/SkComposeShader.cpp
index c49d8a48ae..9e5e2c6a49 100644
--- a/src/core/SkComposeShader.cpp
+++ b/src/core/SkComposeShader.cpp
@@ -1,4 +1,3 @@
-
/*
* Copyright 2006 The Android Open Source Project
*
@@ -6,7 +5,6 @@
* found in the LICENSE file.
*/
-
#include "SkComposeShader.h"
#include "SkColorFilter.h"
#include "SkColorPriv.h"
diff --git a/include/core/SkComposeShader.h b/src/core/SkComposeShader.h
index bc9d932ee5..bc9d932ee5 100644
--- a/include/core/SkComposeShader.h
+++ b/src/core/SkComposeShader.h