aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar bungeman <bungeman@google.com>2016-07-13 10:57:24 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2016-07-13 10:57:24 -0700
commit82945560e61f2996d2749b74359d219f56c92dda (patch)
treeacc728ff249c0df7ef4cd703de1df8fcfe202378
parentb1b12f8666a48b8ff1367beed97bc84032552ac8 (diff)
Disable embedded bitmap test on iOS.
The TypefaceRenderingGM crashes on iOS when drawing an embedded bitmap when requesting aliased rendering. The crash looks like libTrueTypeScaler.dylib`<redacted> + 80 stop reason = EXC_BAD_ACCESS (code=EXC_ARM_DA_ALIGN, address=...) -> 0x330b19d0 <+80>: strd r2, r3, [r5, #36] 0x330b19d4 <+84>: movs r3, #0x0 0x330b19d6 <+86>: add r2, sp, #0x28 0x330b19d8 <+88>: ldr r0, [r4, #0x4] Disable testing embedded bitmaps on iOS for now. BUG=skia:5530 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2140383004 Review-Url: https://codereview.chromium.org/2140383004
-rw-r--r--gm/typeface.cpp14
1 files changed, 14 insertions, 0 deletions
diff --git a/gm/typeface.cpp b/gm/typeface.cpp
index d579a156a6..aa2c61b040 100644
--- a/gm/typeface.cpp
+++ b/gm/typeface.cpp
@@ -194,7 +194,21 @@ protected:
// GASP_SYMMETRIC_SMOOTHING|GASP_SYMMETRIC_GRIDFIT 0x000C 13<=ppem<=14
// (neither) 0x0000 15<=ppem
// Odd sizes have embedded bitmaps.
+#ifdef SK_BUILD_FOR_IOS
+ // This gm crashes on iOS when drawing an embedded bitmap when requesting aliased rendering.
+ // The crash looks like
+ // libTrueTypeScaler.dylib`<redacted> + 80
+ // stop reason = EXC_BAD_ACCESS (code=EXC_ARM_DA_ALIGN, address=...)
+ // -> 0x330b19d0 <+80>: strd r2, r3, [r5, #36]
+ // 0x330b19d4 <+84>: movs r3, #0x0
+ // 0x330b19d6 <+86>: add r2, sp, #0x28
+ // 0x330b19d8 <+88>: ldr r0, [r4, #0x4]
+ // Disable testing embedded bitmaps on iOS for now.
+ // See https://bug.skia.org/5530 .
+ constexpr SkScalar textSizes[] = { 10, 12, 14, 16 };
+#else
constexpr SkScalar textSizes[] = { 9, 10, 11, 12, 13, 14, 15, 16 };
+#endif
constexpr SkPaint::Hinting hintingTypes[] = { SkPaint::kNo_Hinting,
SkPaint::kSlight_Hinting,