aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Mike Reed <reed@google.com>2017-06-08 14:16:03 -0400
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2017-06-08 18:38:43 +0000
commit7c14d274ee6d0e4852aae1ba34873656fdd76ef1 (patch)
treebadf2bc1ff483968f013f53bc31faedd70907de8
parent70bc94f273224ed0755ae11dc479c57ff37e0436 (diff)
Experimental change to diagnose image diffs in g3
Bug: skia: Change-Id: I33226a0266093a98083b4c78cdaba402ce3f3929 Reviewed-on: https://skia-review.googlesource.com/19082 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
-rw-r--r--public.bzl2
-rw-r--r--src/jumper/SkJumper.cpp4
2 files changed, 6 insertions, 0 deletions
diff --git a/public.bzl b/public.bzl
index a4ff4105d3..ea247a6e91 100644
--- a/public.bzl
+++ b/public.bzl
@@ -669,6 +669,8 @@ DEFINES_ALL = [
"SK_WEBP_ENCODER_USE_DEFAULT_METHOD",
# Temporarily Disable analytic AA for Google3
"SK_NO_ANALYTIC_AA",
+ # Experiment to diagnose image diffs in Google3
+ "SK_DISABLE_SSSE3_RUNTIME_CHECK_FOR_LOWP_STAGES",
]
################################################################################
diff --git a/src/jumper/SkJumper.cpp b/src/jumper/SkJumper.cpp
index 82248001f8..f10207a058 100644
--- a/src/jumper/SkJumper.cpp
+++ b/src/jumper/SkJumper.cpp
@@ -30,6 +30,7 @@ static K kConstants = {
static const int kNumStages = SK_RASTER_PIPELINE_STAGES(M);
#undef M
+#ifndef SK_DISABLE_SSSE3_RUNTIME_CHECK_FOR_LOWP_STAGES
#if !__has_feature(memory_sanitizer) && (defined(__x86_64__) || defined(_M_X64))
#if 0
#include <atomic>
@@ -56,6 +57,7 @@ static const int kNumStages = SK_RASTER_PIPELINE_STAGES(M);
static void log_missing(SkRasterPipeline::StockStage) {}
#endif
#endif
+#endif
// We can't express the real types of most stage functions portably, so we use a stand-in.
// We'll only ever call start_pipeline(), which then chains into the rest for us.
@@ -239,6 +241,7 @@ static SkJumper_Engine choose_engine() {
}
StartPipelineFn* SkRasterPipeline::build_pipeline(void** ip) const {
+#ifndef SK_DISABLE_SSSE3_RUNTIME_CHECK_FOR_LOWP_STAGES
#if !__has_feature(memory_sanitizer) && (defined(__x86_64__) || defined(_M_X64))
if (SkCpu::Supports(SkCpu::SSSE3)) {
void** reset_point = ip;
@@ -269,6 +272,7 @@ StartPipelineFn* SkRasterPipeline::build_pipeline(void** ip) const {
}
}
#endif
+#endif
gChooseEngineOnce([]{ gEngine = choose_engine(); });
// We're building the pipeline backwards, so we start with the final stage just_return.