diff options
author | tfarina <tfarina@chromium.org> | 2014-12-20 06:53:43 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-12-20 06:53:43 -0800 |
commit | 752e7eb157f8a18c26b88b7b85eecdbd5549d52e (patch) | |
tree | 796bd41d42d1ebc0dfb65c01173d974b60aebaf8 | |
parent | bb1af8dd75c1db1a4bec34e584d552ebbcb1fedc (diff) |
Cleanup: Another round of override fixes.
BUG=skia:3075
TEST=ninja -C out/Debug
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/815883002
54 files changed, 250 insertions, 253 deletions
diff --git a/gm/imageblur2.cpp b/gm/imageblur2.cpp index b7c9f9d9c8..629d384048 100644 --- a/gm/imageblur2.cpp +++ b/gm/imageblur2.cpp @@ -40,15 +40,15 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return fName; } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(WIDTH, HEIGHT); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { const int sigmaCount = SK_ARRAY_COUNT(kBlurSigmas); const int testStringCount = SK_ARRAY_COUNT(kTestStrings); SkScalar dx = WIDTH / sigmaCount; diff --git a/gm/inversepaths.cpp b/gm/inversepaths.cpp index c7161597c2..64af2b178c 100644 --- a/gm/inversepaths.cpp +++ b/gm/inversepaths.cpp @@ -74,15 +74,15 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("inverse_paths"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(800, 900); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { SkScalar cx = slideWidth / 2 + slideBoundary; SkScalar cy = slideHeight / 2 + slideBoundary; SkScalar dx = slideWidth + 2 * slideBoundary; diff --git a/gm/lighting.cpp b/gm/lighting.cpp index e7842a9c81..e56d9fc0c7 100644 --- a/gm/lighting.cpp +++ b/gm/lighting.cpp @@ -24,7 +24,7 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("lighting"); } @@ -41,7 +41,7 @@ protected: canvas.drawText(str, strlen(str), SkIntToScalar(20), SkIntToScalar(70), paint); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(WIDTH, HEIGHT); } @@ -54,7 +54,7 @@ protected: canvas->restore(); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { if (!fInitialized) { make_bitmap(); fInitialized = true; diff --git a/gm/patheffects.cpp b/gm/patheffects.cpp index 7177a531f1..00ae21529b 100644 --- a/gm/patheffects.cpp +++ b/gm/patheffects.cpp @@ -111,13 +111,13 @@ protected: return kSkipTiled_Flag; } - SkString onShortName() { + SkString onShortName() SK_OVERRIDE { return SkString("patheffect"); } - SkISize onISize() { return SkISize::Make(800, 600); } + SkISize onISize() SK_OVERRIDE { return SkISize::Make(800, 600); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { SkPaint paint; paint.setAntiAlias(true); paint.setStyle(SkPaint::kStroke_Style); diff --git a/gm/pathfill.cpp b/gm/pathfill.cpp index 01811e3c94..80342d6d54 100644 --- a/gm/pathfill.cpp +++ b/gm/pathfill.cpp @@ -129,15 +129,15 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("pathfill"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(640, 480); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { SkPaint paint; paint.setAntiAlias(true); @@ -167,11 +167,11 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("pathinvfill"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(450, 220); } @@ -188,7 +188,7 @@ protected: canvas->restore(); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { SkPath path; path.addCircle(SkIntToScalar(50), SkIntToScalar(50), SkIntToScalar(40)); diff --git a/gm/pathinterior.cpp b/gm/pathinterior.cpp index 559fb8973c..865e32b5de 100644 --- a/gm/pathinterior.cpp +++ b/gm/pathinterior.cpp @@ -25,7 +25,7 @@ public: } protected: - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(770, 770); } diff --git a/gm/pathreverse.cpp b/gm/pathreverse.cpp index fd13404198..7cb7ba1cdc 100644 --- a/gm/pathreverse.cpp +++ b/gm/pathreverse.cpp @@ -72,15 +72,15 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("path-reverse"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(640, 480); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { if (false) test_rev(canvas); // avoid bit rot, suppress warning SkRect r = { 10, 10, 100, 60 }; diff --git a/gm/peekpixels.cpp b/gm/peekpixels.cpp index 01a60c124f..b5573f3458 100644 --- a/gm/peekpixels.cpp +++ b/gm/peekpixels.cpp @@ -64,7 +64,7 @@ protected: } } - virtual uint32_t onGetFlags() const { + virtual uint32_t onGetFlags() const SK_OVERRIDE { // we explicitly test peekPixels and readPixels, neither of which // return something for a picture-backed canvas, so we skip that test. return kSkipPicture_Flag; diff --git a/gm/points.cpp b/gm/points.cpp index b241fe019e..1f9a5811b1 100644 --- a/gm/points.cpp +++ b/gm/points.cpp @@ -19,11 +19,11 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("points"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(640, 490); } @@ -38,7 +38,7 @@ protected: } } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { canvas->translate(SK_Scalar1, SK_Scalar1); SkRandom rand; diff --git a/gm/quadpaths.cpp b/gm/quadpaths.cpp index 1dbb3d090c..f6e9fad07f 100644 --- a/gm/quadpaths.cpp +++ b/gm/quadpaths.cpp @@ -20,11 +20,11 @@ protected: return kSkipTiled_Flag; } - SkString onShortName() { + SkString onShortName() SK_OVERRIDE { return SkString("quadpath"); } - SkISize onISize() { return SkISize::Make(1240, 390); } + SkISize onISize() SK_OVERRIDE { return SkISize::Make(1240, 390); } void drawPath(SkPath& path,SkCanvas* canvas,SkColor color, const SkRect& clip,SkPaint::Cap cap, SkPaint::Join join, @@ -43,7 +43,7 @@ protected: canvas->restore(); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { struct FillAndName { SkPath::FillType fFill; const char* fName; @@ -168,11 +168,11 @@ protected: return kSkipTiled_Flag; } - SkString onShortName() { + SkString onShortName() SK_OVERRIDE { return SkString("quadclosepath"); } - SkISize onISize() { return SkISize::Make(1240, 390); } + SkISize onISize() SK_OVERRIDE { return SkISize::Make(1240, 390); } void drawPath(SkPath& path,SkCanvas* canvas,SkColor color, const SkRect& clip,SkPaint::Cap cap, SkPaint::Join join, @@ -191,7 +191,7 @@ protected: canvas->restore(); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { struct FillAndName { SkPath::FillType fFill; const char* fName; diff --git a/gm/rrect.cpp b/gm/rrect.cpp index 8e26b1b897..a426707b87 100644 --- a/gm/rrect.cpp +++ b/gm/rrect.cpp @@ -130,15 +130,15 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("rrect"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(820, 710); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { static const InsetProc insetProcs[] = { inset0, inset1, inset2, inset3 }; diff --git a/gm/samplerstress.cpp b/gm/samplerstress.cpp index 29be6843f9..fc7d76c569 100644 --- a/gm/samplerstress.cpp +++ b/gm/samplerstress.cpp @@ -32,11 +32,11 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("gpusamplerstress"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(640, 480); } @@ -91,8 +91,7 @@ protected: fMaskFilter.reset(SkBlurMaskFilter::Create(kNormal_SkBlurStyle, sigma)); } - virtual void onDraw(SkCanvas* canvas) { - + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { createShader(); createMaskFilter(); diff --git a/gm/shaderbounds.cpp b/gm/shaderbounds.cpp index 55e334cb3a..6820fc6359 100644 --- a/gm/shaderbounds.cpp +++ b/gm/shaderbounds.cpp @@ -38,11 +38,11 @@ protected: return kSkipTiled_Flag; } - SkString onShortName() { + SkString onShortName() SK_OVERRIDE { return fName; } - virtual SkISize onISize() { return SkISize::Make(320, 240); } + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(320, 240); } virtual SkMatrix onGetInitialTransform() const SK_OVERRIDE { SkMatrix result; @@ -52,7 +52,7 @@ protected: return result; } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { // The PDF device has already clipped to the content area, but we // do it again here so that the raster and pdf results are consistent. canvas->clipRect(SkRect::MakeWH(SkIntToScalar(320), diff --git a/gm/shadertext.cpp b/gm/shadertext.cpp index 37be71092f..30b15735d7 100644 --- a/gm/shadertext.cpp +++ b/gm/shadertext.cpp @@ -95,13 +95,13 @@ protected: return kSkipTiled_Flag; } - SkString onShortName() { + SkString onShortName() SK_OVERRIDE { return SkString("shadertext"); } - SkISize onISize() { return SkISize::Make(1450, 500); } + SkISize onISize() SK_OVERRIDE { return SkISize::Make(1450, 500); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { const char text[] = "Shaded Text"; const int textLen = SK_ARRAY_COUNT(text) - 1; const int pointSize = 36; diff --git a/gm/shadertext2.cpp b/gm/shadertext2.cpp index d73fb6f8f3..d33a203674 100644 --- a/gm/shadertext2.cpp +++ b/gm/shadertext2.cpp @@ -48,13 +48,13 @@ public: protected: - SkString onShortName() { + SkString onShortName() SK_OVERRIDE { return SkString("shadertext2"); } - SkISize onISize() { return SkISize::Make(1800, 900); } + SkISize onISize() SK_OVERRIDE { return SkISize::Make(1800, 900); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { static const char kText[] = "SKIA"; static const int kTextLen = SK_ARRAY_COUNT(kText) - 1; static const int kPointSize = 55; diff --git a/gm/spritebitmap.cpp b/gm/spritebitmap.cpp index a387dd3a9a..f22c429b51 100644 --- a/gm/spritebitmap.cpp +++ b/gm/spritebitmap.cpp @@ -66,15 +66,15 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("spritebitmap"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(640, 480); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { SkBitmap bm; make_bm(&bm); diff --git a/gm/stringart.cpp b/gm/stringart.cpp index 24d7b14442..2d6b737434 100644 --- a/gm/stringart.cpp +++ b/gm/stringart.cpp @@ -27,15 +27,15 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("stringart"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(kWidth, kHeight); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { SkScalar angle = kAngle*SK_ScalarPI + SkScalarHalf(SK_ScalarPI); SkScalar size = SkIntToScalar(SkMin32(kWidth, kHeight)); SkPoint center = SkPoint::Make(SkScalarHalf(kWidth), SkScalarHalf(kHeight)); diff --git a/gm/strokefill.cpp b/gm/strokefill.cpp index 4566eea9ad..85d7b6d5c4 100644 --- a/gm/strokefill.cpp +++ b/gm/strokefill.cpp @@ -23,11 +23,11 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("stroke-fill"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(640, 480); } @@ -39,7 +39,7 @@ protected: canvas->drawText(text, len, x, y + SkIntToScalar(120), p); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { SkScalar x = SkIntToScalar(100); SkScalar y = SkIntToScalar(88); diff --git a/gm/strokerect.cpp b/gm/strokerect.cpp index 9c86aec642..4d0353f28c 100644 --- a/gm/strokerect.cpp +++ b/gm/strokerect.cpp @@ -50,15 +50,15 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("strokerect"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(1024, 740); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { canvas->drawColor(SK_ColorWHITE); canvas->translate(STROKE_WIDTH*3/2, STROKE_WIDTH*3/2); diff --git a/gm/strokerects.cpp b/gm/strokerects.cpp index 65eadd1a90..2a187b7544 100644 --- a/gm/strokerects.cpp +++ b/gm/strokerects.cpp @@ -29,11 +29,11 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("strokerects"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(W*2, H*2); } @@ -49,7 +49,7 @@ protected: r->offset(-w/2 + woffset, -h/2 + hoffset); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { SkPaint paint; paint.setStyle(SkPaint::kStroke_Style); diff --git a/gm/strokes.cpp b/gm/strokes.cpp index 2a92c031ae..0a8f121b49 100644 --- a/gm/strokes.cpp +++ b/gm/strokes.cpp @@ -43,15 +43,15 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("strokes_round"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(W, H*2); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { SkPaint paint; paint.setStyle(SkPaint::kStroke_Style); paint.setStrokeWidth(SkIntToScalar(9)/2); @@ -99,11 +99,11 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("strokes_poly"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(W, H*2); } @@ -113,7 +113,7 @@ protected: canvas->concat(matrix); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { canvas->drawColor(SK_ColorWHITE); SkPaint paint; @@ -200,15 +200,15 @@ protected: return kSkipTiled_Flag; } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("strokes3"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(W, H*2); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { SkPaint origPaint; origPaint.setAntiAlias(true); origPaint.setStyle(SkPaint::kStroke_Style); diff --git a/gm/testimagefilters.cpp b/gm/testimagefilters.cpp index 799b44c017..50df0e6aef 100644 --- a/gm/testimagefilters.cpp +++ b/gm/testimagefilters.cpp @@ -97,7 +97,7 @@ public: protected: - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("testimagefilters"); } @@ -105,9 +105,9 @@ protected: return kSkipTiled_Flag; } - virtual SkISize onISize() { return SkISize::Make(700, 460); } + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(700, 460); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { // this->drawSizeBounds(canvas, 0xFFCCCCCC); static SkImageFilter* (*gFilterProc[])() = { diff --git a/gm/texdata.cpp b/gm/texdata.cpp index b8c2431c9b..379898a741 100644 --- a/gm/texdata.cpp +++ b/gm/texdata.cpp @@ -27,17 +27,17 @@ public: } protected: - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("texdata"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(2*S, 2*S); } virtual uint32_t onGetFlags() const SK_OVERRIDE { return kGPUOnly_Flag; } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { GrRenderTarget* target = canvas->internal_private_accessTopLayerRenderTarget(); GrContext* ctx = canvas->getGrContext(); if (ctx && target) { diff --git a/gm/tiledscaledbitmap.cpp b/gm/tiledscaledbitmap.cpp index 3ea110c44f..4bf3b824eb 100644 --- a/gm/tiledscaledbitmap.cpp +++ b/gm/tiledscaledbitmap.cpp @@ -31,11 +31,11 @@ public: } protected: - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("tiledscaledbitmap"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(1016, 616); } @@ -43,7 +43,7 @@ protected: return kSkipTiled_Flag; } - static SkBitmap make_bm(int width, int height) { + static SkBitmap make_bm(int width, int height) { SkBitmap bm; bm.allocN32Pixels(width, height); bm.eraseColor(SK_ColorTRANSPARENT); @@ -51,14 +51,14 @@ protected: SkPaint paint; paint.setAntiAlias(true); canvas.drawCircle(width/2.f, height/2.f, width/4.f, paint); - return bm; + return bm; } virtual void onOnceBeforeDraw() SK_OVERRIDE { fBitmap = make_bm(360, 288); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { SkPaint paint; paint.setAntiAlias(true); diff --git a/gm/tilemodes.cpp b/gm/tilemodes.cpp index a912cba5e7..33d1b23471 100644 --- a/gm/tilemodes.cpp +++ b/gm/tilemodes.cpp @@ -61,7 +61,7 @@ protected: kNPOTSize = 21, }; - SkString onShortName() { + SkString onShortName() SK_OVERRIDE { SkString name("tilemodes"); if (!fPowerOfTwoSize) { name.append("_npot"); @@ -69,7 +69,7 @@ protected: return name; } - SkISize onISize() { return SkISize::Make(880, 560); } + SkISize onISize() SK_OVERRIDE { return SkISize::Make(880, 560); } virtual void onOnceBeforeDraw() SK_OVERRIDE { int size = fPowerOfTwoSize ? kPOTSize : kNPOTSize; @@ -198,13 +198,13 @@ protected: return kSkipTiled_Flag; } - SkString onShortName() { + SkString onShortName() SK_OVERRIDE { return fName; } - SkISize onISize() { return SkISize::Make(880, 560); } + SkISize onISize() SK_OVERRIDE { return SkISize::Make(880, 560); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { canvas->scale(SkIntToScalar(3)/2, SkIntToScalar(3)/2); const SkScalar w = SkIntToScalar(gWidth); diff --git a/gm/tilemodes_scaled.cpp b/gm/tilemodes_scaled.cpp index 93a3db3f90..32f640acaa 100644 --- a/gm/tilemodes_scaled.cpp +++ b/gm/tilemodes_scaled.cpp @@ -65,7 +65,7 @@ protected: kNPOTSize = 3, }; - SkString onShortName() { + SkString onShortName() SK_OVERRIDE { SkString name("scaled_tilemodes"); if (!fPowerOfTwoSize) { name.append("_npot"); @@ -80,7 +80,7 @@ protected: } #endif - SkISize onISize() { return SkISize::Make(880, 760); } + SkISize onISize() SK_OVERRIDE { return SkISize::Make(880, 760); } virtual void onOnceBeforeDraw() SK_OVERRIDE { int size = fPowerOfTwoSize ? kPOTSize : kNPOTSize; @@ -90,7 +90,6 @@ protected: } virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { - float scale = 32.f/kPOTSize; int size = fPowerOfTwoSize ? kPOTSize : kNPOTSize; @@ -218,13 +217,13 @@ protected: return kSkipTiled_Flag; } - SkString onShortName() { + SkString onShortName() SK_OVERRIDE { return fName; } - SkISize onISize() { return SkISize::Make(880, 560); } + SkISize onISize() SK_OVERRIDE { return SkISize::Make(880, 560); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { canvas->scale(SkIntToScalar(3)/2, SkIntToScalar(3)/2); const SkScalar w = SkIntToScalar(gWidth); diff --git a/gm/verttext.cpp b/gm/verttext.cpp index 944a6db876..0804e09110 100644 --- a/gm/verttext.cpp +++ b/gm/verttext.cpp @@ -53,11 +53,11 @@ protected: return kSkipTiled_Flag; } - SkString onShortName() { + SkString onShortName() SK_OVERRIDE { return SkString("verttext"); } - SkISize onISize() { return SkISize::Make(640, 480); } + SkISize onISize() SK_OVERRIDE { return SkISize::Make(640, 480); } static void drawBaseline(SkCanvas* canvas, const SkPaint& paint, SkScalar x, SkScalar y) { @@ -85,7 +85,7 @@ protected: canvas->drawCircle(x, y, SK_Scalar1 * 3 / 2, p); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { SkScalar x = SkIntToScalar(100); SkScalar y = SkIntToScalar(50); diff --git a/gm/verttext2.cpp b/gm/verttext2.cpp index 0ccdec19ca..5067bbb745 100644 --- a/gm/verttext2.cpp +++ b/gm/verttext2.cpp @@ -36,14 +36,13 @@ protected: } - SkString onShortName() { + SkString onShortName() SK_OVERRIDE { return SkString("verttext2"); } - SkISize onISize() { return SkISize::Make(640, 480); } - - virtual void onDraw(SkCanvas* canvas) { + SkISize onISize() SK_OVERRIDE { return SkISize::Make(640, 480); } + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { for (int i = 0; i < 3; ++i) { SkPaint paint; paint.setColor(SK_ColorRED); diff --git a/gm/xfermodes.cpp b/gm/xfermodes.cpp index d881ae1e6d..c8fc1ba876 100644 --- a/gm/xfermodes.cpp +++ b/gm/xfermodes.cpp @@ -168,15 +168,15 @@ public: XfermodesGM() {} protected: - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("xfermodes"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(1990, 640); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { canvas->translate(SkIntToScalar(10), SkIntToScalar(20)); const struct { diff --git a/src/animator/SkAnimate.h b/src/animator/SkAnimate.h index 1bbecf90cf..f6541243e4 100644 --- a/src/animator/SkAnimate.h +++ b/src/animator/SkAnimate.h @@ -19,11 +19,11 @@ class SkAnimate : public SkAnimateBase { DECLARE_MEMBER_INFO(Animate); SkAnimate(); virtual ~SkAnimate(); - virtual int components(); + virtual int components() SK_OVERRIDE; #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif - virtual void onEndElement(SkAnimateMaker& maker); + virtual void onEndElement(SkAnimateMaker& maker) SK_OVERRIDE; protected: bool resolveCommon(SkAnimateMaker& ); int fComponents; diff --git a/src/animator/SkAnimateBase.h b/src/animator/SkAnimateBase.h index 9cf07583c8..63ee537bd3 100644 --- a/src/animator/SkAnimateBase.h +++ b/src/animator/SkAnimateBase.h @@ -24,26 +24,26 @@ public: SkAnimateBase(); virtual ~SkAnimateBase(); virtual int components(); - virtual SkDisplayable* deepCopy(SkAnimateMaker* ); - virtual void dirty(); + virtual SkDisplayable* deepCopy(SkAnimateMaker* ) SK_OVERRIDE; + virtual void dirty() SK_OVERRIDE; #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif int entries() { return fValues.count() / components(); } virtual bool hasExecute() const; bool isDynamic() const { return SkToBool(fDynamic); } - virtual SkDisplayable* getParent() const; - virtual bool getProperty(int index, SkScriptValue* value) const; + virtual SkDisplayable* getParent() const SK_OVERRIDE; + virtual bool getProperty(int index, SkScriptValue* value) const SK_OVERRIDE; SkMSec getStart() const { return fStart; } SkOperand* getValues() { return fValues.begin(); } SkDisplayTypes getValuesType() { return fValues.getType(); } - virtual void onEndElement(SkAnimateMaker& ); + virtual void onEndElement(SkAnimateMaker& ) SK_OVERRIDE; void packARGB(SkScalar [], int count, SkTDOperandArray* ); virtual void refresh(SkAnimateMaker& ); void setChanged(bool changed) { fChanged = changed; } void setHasEndEvent() { fHasEndEvent = true; } - virtual bool setParent(SkDisplayable* ); - virtual bool setProperty(int index, SkScriptValue& value); + virtual bool setParent(SkDisplayable* ) SK_OVERRIDE; + virtual bool setProperty(int index, SkScriptValue& value) SK_OVERRIDE; void setTarget(SkAnimateMaker& ); virtual bool targetNeedsInitialization() const; protected: diff --git a/src/animator/SkAnimateSet.h b/src/animator/SkAnimateSet.h index b8f7bf54f6..6f38e9eaa9 100644 --- a/src/animator/SkAnimateSet.h +++ b/src/animator/SkAnimateSet.h @@ -16,10 +16,10 @@ class SkSet : public SkAnimate { DECLARE_MEMBER_INFO(Set); SkSet(); #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif - virtual void onEndElement(SkAnimateMaker& ); - virtual void refresh(SkAnimateMaker& ); + virtual void onEndElement(SkAnimateMaker& ) SK_OVERRIDE; + virtual void refresh(SkAnimateMaker& ) SK_OVERRIDE; private: typedef SkAnimate INHERITED; }; diff --git a/src/animator/SkDisplayAdd.h b/src/animator/SkDisplayAdd.h index ebb73f1ec6..6ba4933acd 100644 --- a/src/animator/SkDisplayAdd.h +++ b/src/animator/SkDisplayAdd.h @@ -22,15 +22,15 @@ class SkAdd : public SkADrawable { kMode_immediate }; - virtual SkDisplayable* deepCopy(SkAnimateMaker* ); - virtual bool draw(SkAnimateMaker& ); + virtual SkDisplayable* deepCopy(SkAnimateMaker* ) SK_OVERRIDE; + virtual bool draw(SkAnimateMaker& ) SK_OVERRIDE; #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif - virtual bool enable(SkAnimateMaker& ); - virtual bool hasEnable() const; - virtual void initialize(); - virtual bool isDrawable() const; + virtual bool enable(SkAnimateMaker& ) SK_OVERRIDE; + virtual bool hasEnable() const SK_OVERRIDE; + virtual void initialize() SK_OVERRIDE; + virtual bool isDrawable() const SK_OVERRIDE; protected: // struct _A { Mode mode; diff --git a/src/animator/SkDisplayApply.h b/src/animator/SkDisplayApply.h index 0cfab51031..2d09fbec1e 100644 --- a/src/animator/SkDisplayApply.h +++ b/src/animator/SkDisplayApply.h @@ -38,41 +38,41 @@ public: void appendActive(SkActive* ); void applyValues(int animatorIndex, SkOperand* values, int count, SkDisplayTypes , SkMSec time); - virtual bool contains(SkDisplayable*); + virtual bool contains(SkDisplayable*) SK_OVERRIDE; // void createActive(SkAnimateMaker& ); - virtual SkDisplayable* deepCopy(SkAnimateMaker* ); + virtual SkDisplayable* deepCopy(SkAnimateMaker* ) SK_OVERRIDE; void disable(); - virtual bool draw(SkAnimateMaker& ); + virtual bool draw(SkAnimateMaker& ) SK_OVERRIDE; #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif - virtual bool enable(SkAnimateMaker& ); + virtual bool enable(SkAnimateMaker& ) SK_OVERRIDE; void enableCreate(SkAnimateMaker& ); void enableDynamic(SkAnimateMaker& ); void endSave(int index); Mode getMode() { return mode; } - virtual bool getProperty(int index, SkScriptValue* value) const; + virtual bool getProperty(int index, SkScriptValue* value) const SK_OVERRIDE; SkADrawable* getScope() { return scope; } void getStep(SkScriptValue* ); SkADrawable* getTarget(SkAnimateBase* ); bool hasDelayedAnimator() const; - virtual bool hasEnable() const; + virtual bool hasEnable() const SK_OVERRIDE; bool inactivate(SkAnimateMaker& maker); - virtual void initialize(); + virtual void initialize() SK_OVERRIDE; bool interpolate(SkAnimateMaker& , SkMSec time); - virtual void onEndElement(SkAnimateMaker& ); - virtual const SkMemberInfo* preferredChild(SkDisplayTypes type); + virtual void onEndElement(SkAnimateMaker& ) SK_OVERRIDE; + virtual const SkMemberInfo* preferredChild(SkDisplayTypes type) SK_OVERRIDE; void refresh(SkAnimateMaker& ); void reset(); - virtual bool resolveIDs(SkAnimateMaker& maker, SkDisplayable* original, SkApply* ); + virtual bool resolveIDs(SkAnimateMaker& maker, SkDisplayable* original, SkApply* ) SK_OVERRIDE; bool resolveField(SkAnimateMaker& , SkDisplayable* parent, SkString* str); void save(int index); void setEmbedded() { fEmbedded = true; } - virtual bool setProperty(int index, SkScriptValue& ); - virtual void setSteps(int _steps); + virtual bool setProperty(int index, SkScriptValue& ) SK_OVERRIDE; + virtual void setSteps(int _steps) SK_OVERRIDE; // virtual void setTime(SkMSec time); #ifdef SK_DEBUG - virtual void validate(); + virtual void validate() SK_OVERRIDE; #endif private: SkMSec begin; diff --git a/src/animator/SkDisplayBounds.h b/src/animator/SkDisplayBounds.h index 0511ed7439..7ca1cc57c1 100644 --- a/src/animator/SkDisplayBounds.h +++ b/src/animator/SkDisplayBounds.h @@ -15,7 +15,7 @@ class SkDisplayBounds : public SkDrawRect { DECLARE_DISPLAY_MEMBER_INFO(Bounds); SkDisplayBounds(); - virtual bool draw(SkAnimateMaker& ); + virtual bool draw(SkAnimateMaker& ) SK_OVERRIDE; private: SkBool inval; typedef SkDrawRect INHERITED; diff --git a/src/animator/SkDisplayEvent.h b/src/animator/SkDisplayEvent.h index 952faeac63..92eb8cf2e9 100644 --- a/src/animator/SkDisplayEvent.h +++ b/src/animator/SkDisplayEvent.h @@ -35,16 +35,16 @@ class SkDisplayEvent : public SkDisplayable { SkDisplayEvent(); virtual ~SkDisplayEvent(); virtual bool addChild(SkAnimateMaker& , SkDisplayable* child) SK_OVERRIDE; - virtual bool contains(SkDisplayable*); - virtual SkDisplayable* contains(const SkString& ); + virtual bool contains(SkDisplayable*) SK_OVERRIDE; + virtual SkDisplayable* contains(const SkString& ) SK_OVERRIDE; #ifdef SK_DEBUG void dumpEvent(SkAnimateMaker* ); #endif bool enableEvent(SkAnimateMaker& ); - virtual bool getProperty(int index, SkScriptValue* ) const; - virtual void onEndElement(SkAnimateMaker& maker); + virtual bool getProperty(int index, SkScriptValue* ) const SK_OVERRIDE; + virtual void onEndElement(SkAnimateMaker& maker) SK_OVERRIDE; void populateInput(SkAnimateMaker& , const SkEvent& fEvent); - virtual bool setProperty(int index, SkScriptValue& ); + virtual bool setProperty(int index, SkScriptValue& ) SK_OVERRIDE; protected: SkKey code; SkBool disable; diff --git a/src/animator/SkDisplayInclude.h b/src/animator/SkDisplayInclude.h index 41b5d29740..9e0cfe2cb5 100644 --- a/src/animator/SkDisplayInclude.h +++ b/src/animator/SkDisplayInclude.h @@ -15,9 +15,9 @@ class SkInclude : public SkDisplayable { DECLARE_MEMBER_INFO(Include); - virtual void onEndElement(SkAnimateMaker & ); - virtual bool enable(SkAnimateMaker & ); - virtual bool hasEnable() const; + virtual void onEndElement(SkAnimateMaker & ) SK_OVERRIDE; + virtual bool enable(SkAnimateMaker & ) SK_OVERRIDE; + virtual bool hasEnable() const SK_OVERRIDE; protected: SkString src; }; diff --git a/src/animator/SkDisplayInput.h b/src/animator/SkDisplayInput.h index d9871e211e..045a2e4eed 100644 --- a/src/animator/SkDisplayInput.h +++ b/src/animator/SkDisplayInput.h @@ -16,10 +16,10 @@ class SkInput : public SkDisplayable { DECLARE_MEMBER_INFO(Input); SkInput(); - virtual SkDisplayable* contains(const SkString& ); - virtual bool getProperty(int index, SkScriptValue* value) const; - virtual bool enable(SkAnimateMaker & ); - virtual bool hasEnable() const; + virtual SkDisplayable* contains(const SkString& ) SK_OVERRIDE; + virtual bool getProperty(int index, SkScriptValue* value) const SK_OVERRIDE; + virtual bool enable(SkAnimateMaker & ) SK_OVERRIDE; + virtual bool hasEnable() const SK_OVERRIDE; protected: SkString name; int32_t fInt; diff --git a/src/animator/SkDisplayMovie.h b/src/animator/SkDisplayMovie.h index d43ebf4f00..cc944f56b6 100644 --- a/src/animator/SkDisplayMovie.h +++ b/src/animator/SkDisplayMovie.h @@ -21,21 +21,21 @@ class SkDisplayMovie : public SkADrawable { SkDisplayMovie(); virtual ~SkDisplayMovie(); void buildMovie(); - virtual SkDisplayable* deepCopy(SkAnimateMaker* ); - virtual void dirty(); + virtual SkDisplayable* deepCopy(SkAnimateMaker* ) SK_OVERRIDE; + virtual void dirty() SK_OVERRIDE; bool doEvent(const SkEvent& evt) { return fLoaded && fMovie.doEvent(evt); } - virtual bool doEvent(SkDisplayEvent::Kind , SkEventState* state ); - virtual bool draw(SkAnimateMaker& ); + virtual bool doEvent(SkDisplayEvent::Kind , SkEventState* state ) SK_OVERRIDE; + virtual bool draw(SkAnimateMaker& ) SK_OVERRIDE; #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); - virtual void dumpEvents(); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; + virtual void dumpEvents() SK_OVERRIDE; #endif - virtual bool enable(SkAnimateMaker& ); + virtual bool enable(SkAnimateMaker& ) SK_OVERRIDE; const SkAnimator* getAnimator() const { return &fMovie; } - virtual bool hasEnable() const; - virtual void onEndElement(SkAnimateMaker& ); + virtual bool hasEnable() const SK_OVERRIDE; + virtual void onEndElement(SkAnimateMaker& ) SK_OVERRIDE; protected: SkString src; SkAnimator fMovie; diff --git a/src/animator/SkDisplayNumber.h b/src/animator/SkDisplayNumber.h index 16c6f4fde4..2fc75b780c 100644 --- a/src/animator/SkDisplayNumber.h +++ b/src/animator/SkDisplayNumber.h @@ -15,7 +15,7 @@ class SkDisplayNumber : public SkDisplayable { DECLARE_DISPLAY_MEMBER_INFO(Number); - virtual bool getProperty(int index, SkScriptValue* value) const; + virtual bool getProperty(int index, SkScriptValue* value) const SK_OVERRIDE; private: }; diff --git a/src/animator/SkDisplayPost.h b/src/animator/SkDisplayPost.h index cd22306840..6808292aa6 100644 --- a/src/animator/SkDisplayPost.h +++ b/src/animator/SkDisplayPost.h @@ -28,16 +28,16 @@ class SkPost : public SkDisplayable { SkPost(); virtual ~SkPost(); virtual bool addChild(SkAnimateMaker& , SkDisplayable* child) SK_OVERRIDE; - virtual bool childrenNeedDisposing() const; - virtual void dirty(); + virtual bool childrenNeedDisposing() const SK_OVERRIDE; + virtual void dirty() SK_OVERRIDE; #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif - virtual bool enable(SkAnimateMaker& ); - virtual bool hasEnable() const; - virtual void onEndElement(SkAnimateMaker& ); - virtual void setChildHasID(); - virtual bool setProperty(int index, SkScriptValue& ); + virtual bool enable(SkAnimateMaker& ) SK_OVERRIDE; + virtual bool hasEnable() const SK_OVERRIDE; + virtual void onEndElement(SkAnimateMaker& ) SK_OVERRIDE; + virtual void setChildHasID() SK_OVERRIDE; + virtual bool setProperty(int index, SkScriptValue& ) SK_OVERRIDE; protected: SkMSec delay; SkString sink; diff --git a/src/animator/SkDisplayRandom.h b/src/animator/SkDisplayRandom.h index 1c3865333f..e649fce9d7 100644 --- a/src/animator/SkDisplayRandom.h +++ b/src/animator/SkDisplayRandom.h @@ -26,10 +26,10 @@ class SkDisplayRandom : public SkDisplayable { DECLARE_DISPLAY_MEMBER_INFO(Random); SkDisplayRandom(); #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif - virtual bool getProperty(int index, SkScriptValue* value) const; - virtual bool setProperty(int index, SkScriptValue& ); + virtual bool getProperty(int index, SkScriptValue* value) const SK_OVERRIDE; + virtual bool setProperty(int index, SkScriptValue& ) SK_OVERRIDE; private: SkScalar blend; SkScalar min; diff --git a/src/animator/SkDisplayTypes.h b/src/animator/SkDisplayTypes.h index 1a3d0e5aa7..01a68d0184 100644 --- a/src/animator/SkDisplayTypes.h +++ b/src/animator/SkDisplayTypes.h @@ -34,7 +34,7 @@ class SkDisplayBoolean : public SkDisplayDepend { DECLARE_DISPLAY_MEMBER_INFO(Boolean); SkDisplayBoolean(); #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif SkBool value; friend class SkAnimatorScript; @@ -47,7 +47,7 @@ class SkDisplayInt : public SkDisplayDepend { DECLARE_DISPLAY_MEMBER_INFO(Int); SkDisplayInt(); #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif private: int32_t value; @@ -61,7 +61,7 @@ class SkDisplayFloat : public SkDisplayDepend { DECLARE_DISPLAY_MEMBER_INFO(Float); SkDisplayFloat(); #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif private: SkScalar value; @@ -77,9 +77,9 @@ class SkDisplayString : public SkDisplayDepend { SkDisplayString(SkString& ); virtual void executeFunction(SkDisplayable* , int index, SkTDArray<SkScriptValue>& parameters, SkDisplayTypes type, - SkScriptValue* ); - virtual const SkFunctionParamType* getFunctionsParameters(); - virtual bool getProperty(int index, SkScriptValue* ) const; + SkScriptValue* ) SK_OVERRIDE; + virtual const SkFunctionParamType* getFunctionsParameters() SK_OVERRIDE; + virtual bool getProperty(int index, SkScriptValue* ) const SK_OVERRIDE; SkString value; private: static const SkFunctionParamType fFunctionParameters[]; @@ -91,7 +91,7 @@ class SkDisplayArray : public SkDisplayDepend { SkDisplayArray(SkTypedArray& ); SkDisplayArray(SkOpArray& ); // compiled script experiment virtual ~SkDisplayArray(); - virtual bool getProperty(int index, SkScriptValue* ) const; + virtual bool getProperty(int index, SkScriptValue* ) const SK_OVERRIDE; private: SkTypedArray values; friend class SkAnimator; diff --git a/src/animator/SkDrawBitmap.h b/src/animator/SkDrawBitmap.h index f9a92126b5..0ebea9c6de 100644 --- a/src/animator/SkDrawBitmap.h +++ b/src/animator/SkDrawBitmap.h @@ -20,7 +20,7 @@ class SkBaseBitmap : public SkBoundable { DECLARE_MEMBER_INFO(BaseBitmap); SkBaseBitmap(); virtual ~SkBaseBitmap(); - virtual bool draw(SkAnimateMaker& ); + virtual bool draw(SkAnimateMaker& ) SK_OVERRIDE; protected: SkBitmap fBitmap; SkScalar x; @@ -36,10 +36,10 @@ class SkDrawBitmap : public SkBaseBitmap { SkDrawBitmap(); virtual ~SkDrawBitmap(); #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif - virtual void onEndElement(SkAnimateMaker& ); - virtual bool setProperty(int index, SkScriptValue& value); + virtual void onEndElement(SkAnimateMaker& ) SK_OVERRIDE; + virtual bool setProperty(int index, SkScriptValue& value) SK_OVERRIDE; protected: int /*SkBitmap::Config*/ format; int32_t height; @@ -54,11 +54,11 @@ class SkImageBaseBitmap : public SkBaseBitmap { DECLARE_MEMBER_INFO(ImageBaseBitmap); SkImageBaseBitmap(); virtual ~SkImageBaseBitmap(); - virtual SkDisplayable* deepCopy(SkAnimateMaker* ); - virtual void dirty(); - virtual bool draw(SkAnimateMaker& ); - virtual bool getProperty(int index, SkScriptValue* value) const; - virtual void onEndElement(SkAnimateMaker& maker); + virtual SkDisplayable* deepCopy(SkAnimateMaker* ) SK_OVERRIDE; + virtual void dirty() SK_OVERRIDE; + virtual bool draw(SkAnimateMaker& ) SK_OVERRIDE; + virtual bool getProperty(int index, SkScriptValue* value) const SK_OVERRIDE; + virtual void onEndElement(SkAnimateMaker& maker) SK_OVERRIDE; private: void resolve() const { (const_cast<SkImageBaseBitmap*>(this))->resolve(); } void resolve(); diff --git a/src/animator/SkDrawColor.h b/src/animator/SkDrawColor.h index 17d1eef319..5ce495eec0 100644 --- a/src/animator/SkDrawColor.h +++ b/src/animator/SkDrawColor.h @@ -14,18 +14,18 @@ class SkDrawColor : public SkPaintPart { DECLARE_DRAW_MEMBER_INFO(Color); SkDrawColor(); - virtual bool add(); - virtual void dirty(); + virtual bool add() SK_OVERRIDE; + virtual void dirty() SK_OVERRIDE; #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif SkColor getColor(); - virtual SkDisplayable* deepCopy(SkAnimateMaker* ); - virtual SkDisplayable* getParent() const; - virtual bool getProperty(int index, SkScriptValue* value) const; - virtual void onEndElement(SkAnimateMaker& ); - virtual bool setParent(SkDisplayable* parent); - virtual bool setProperty(int index, SkScriptValue&); + virtual SkDisplayable* deepCopy(SkAnimateMaker* ) SK_OVERRIDE; + virtual SkDisplayable* getParent() const SK_OVERRIDE; + virtual bool getProperty(int index, SkScriptValue* value) const SK_OVERRIDE; + virtual void onEndElement(SkAnimateMaker& ) SK_OVERRIDE; + virtual bool setParent(SkDisplayable* parent) SK_OVERRIDE; + virtual bool setProperty(int index, SkScriptValue&) SK_OVERRIDE; protected: SkColor color; SkScalar fHue; diff --git a/src/animator/SkDrawGradient.h b/src/animator/SkDrawGradient.h index fa46a9e629..e461d44497 100644 --- a/src/animator/SkDrawGradient.h +++ b/src/animator/SkDrawGradient.h @@ -36,11 +36,11 @@ private: class SkDrawLinearGradient : public SkDrawGradient { DECLARE_MEMBER_INFO(DrawLinearGradient); SkDrawLinearGradient(); - virtual void onEndElement(SkAnimateMaker& ); + virtual void onEndElement(SkAnimateMaker& ) SK_OVERRIDE; #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker*); + virtual void dump(SkAnimateMaker*) SK_OVERRIDE; #endif - virtual SkShader* getShader(); + virtual SkShader* getShader() SK_OVERRIDE; protected: SkTDScalarArray points; private: @@ -51,7 +51,7 @@ class SkDrawRadialGradient : public SkDrawGradient { DECLARE_MEMBER_INFO(DrawRadialGradient); SkDrawRadialGradient(); #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker*); + virtual void dump(SkAnimateMaker*) SK_OVERRIDE; #endif virtual SkShader* getShader(); protected: diff --git a/src/animator/SkDrawGroup.h b/src/animator/SkDrawGroup.h index abc3eb7907..a6bebf0e64 100644 --- a/src/animator/SkDrawGroup.h +++ b/src/animator/SkDrawGroup.h @@ -20,34 +20,34 @@ public: SkGroup(); virtual ~SkGroup(); virtual bool addChild(SkAnimateMaker& , SkDisplayable* child) SK_OVERRIDE; - virtual bool contains(SkDisplayable* ); + virtual bool contains(SkDisplayable* ) SK_OVERRIDE; SkGroup* copy(); SkBool copySet(int index); - virtual SkDisplayable* deepCopy(SkAnimateMaker* ); - virtual bool doEvent(SkDisplayEvent::Kind , SkEventState* state ); - virtual bool draw(SkAnimateMaker& ); + virtual SkDisplayable* deepCopy(SkAnimateMaker* ) SK_OVERRIDE; + virtual bool doEvent(SkDisplayEvent::Kind , SkEventState* state ) SK_OVERRIDE; + virtual bool draw(SkAnimateMaker& ) SK_OVERRIDE; #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; virtual void dumpDrawables(SkAnimateMaker* ); - virtual void dumpEvents(); + virtual void dumpEvents() SK_OVERRIDE; #endif int findGroup(SkADrawable* drawable, SkTDDrawableArray** list, SkGroup** parent, SkGroup** found, SkTDDrawableArray** grandList); - virtual bool enable(SkAnimateMaker& ); + virtual bool enable(SkAnimateMaker& ) SK_OVERRIDE; SkTDDrawableArray* getChildren() { return &fChildren; } SkGroup* getOriginal() { return fOriginal; } - virtual bool hasEnable() const; - virtual void initialize(); + virtual bool hasEnable() const SK_OVERRIDE; + virtual void initialize() SK_OVERRIDE; SkBool isACopy() { return fOriginal != NULL; } void markCopyClear(int index); void markCopySet(int index); void markCopySize(int index); bool markedForDelete(int index) const { return (fCopies[index >> 5] & 1 << (index & 0x1f)) == 0; } void reset(); - bool resolveIDs(SkAnimateMaker& maker, SkDisplayable* original, SkApply* ); - virtual void setSteps(int steps); + bool resolveIDs(SkAnimateMaker& maker, SkDisplayable* original, SkApply* ) SK_OVERRIDE; + virtual void setSteps(int steps) SK_OVERRIDE; #ifdef SK_DEBUG - virtual void validate(); + virtual void validate() SK_OVERRIDE; #endif protected: bool ifCondition(SkAnimateMaker& maker, SkADrawable* drawable, @@ -64,7 +64,7 @@ private: class SkSave: public SkGroup { DECLARE_MEMBER_INFO(Save); - virtual bool draw(SkAnimateMaker& ); + virtual bool draw(SkAnimateMaker& ) SK_OVERRIDE; private: typedef SkGroup INHERITED; }; diff --git a/src/animator/SkDrawMatrix.h b/src/animator/SkDrawMatrix.h index 0de83341c9..60eb8e7db7 100644 --- a/src/animator/SkDrawMatrix.h +++ b/src/animator/SkDrawMatrix.h @@ -22,24 +22,24 @@ class SkDrawMatrix : public SkADrawable { SkDrawMatrix(); virtual ~SkDrawMatrix(); virtual bool addChild(SkAnimateMaker& , SkDisplayable* child) SK_OVERRIDE; - virtual bool childrenNeedDisposing() const; - virtual void dirty(); - virtual bool draw(SkAnimateMaker& ); + virtual bool childrenNeedDisposing() const SK_OVERRIDE; + virtual void dirty() SK_OVERRIDE; + virtual bool draw(SkAnimateMaker& ) SK_OVERRIDE; #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif SkMatrix& getMatrix(); - virtual bool getProperty(int index, SkScriptValue* value) const; - virtual void initialize(); - virtual void onEndElement(SkAnimateMaker& ); - virtual void setChildHasID(); - virtual bool setProperty(int index, SkScriptValue& ); + virtual bool getProperty(int index, SkScriptValue* value) const SK_OVERRIDE; + virtual void initialize() SK_OVERRIDE; + virtual void onEndElement(SkAnimateMaker& ) SK_OVERRIDE; + virtual void setChildHasID() SK_OVERRIDE; + virtual bool setProperty(int index, SkScriptValue& ) SK_OVERRIDE; void concat(SkMatrix& inMatrix) { fConcat.preConcat(inMatrix); } - virtual SkDisplayable* deepCopy(SkAnimateMaker* ); + virtual SkDisplayable* deepCopy(SkAnimateMaker* ) SK_OVERRIDE; void rotate(SkScalar degrees, SkPoint& center) { diff --git a/src/animator/SkDrawOval.h b/src/animator/SkDrawOval.h index 3c09e0fa06..803568817f 100644 --- a/src/animator/SkDrawOval.h +++ b/src/animator/SkDrawOval.h @@ -14,7 +14,7 @@ class SkOval : public SkDrawRect { DECLARE_MEMBER_INFO(Oval); - virtual bool draw(SkAnimateMaker& ); + virtual bool draw(SkAnimateMaker& ) SK_OVERRIDE; private: typedef SkDrawRect INHERITED; }; diff --git a/src/animator/SkDrawRectangle.h b/src/animator/SkDrawRectangle.h index 42af02b1e7..a9fb884b0a 100644 --- a/src/animator/SkDrawRectangle.h +++ b/src/animator/SkDrawRectangle.h @@ -19,15 +19,15 @@ class SkRectToRect; class SkDrawRect : public SkBoundable { DECLARE_DRAW_MEMBER_INFO(Rect); SkDrawRect(); - virtual void dirty(); - virtual bool draw(SkAnimateMaker& ); + virtual void dirty() SK_OVERRIDE; + virtual bool draw(SkAnimateMaker& ) SK_OVERRIDE; #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif - virtual SkDisplayable* getParent() const; - virtual bool getProperty(int index, SkScriptValue* value) const; - virtual bool setParent(SkDisplayable* parent); - virtual bool setProperty(int index, SkScriptValue& ); + virtual SkDisplayable* getParent() const SK_OVERRIDE; + virtual bool getProperty(int index, SkScriptValue* value) const SK_OVERRIDE; + virtual bool setParent(SkDisplayable* parent) SK_OVERRIDE; + virtual bool setProperty(int index, SkScriptValue& ) SK_OVERRIDE; protected: SkRect fRect; SkDisplayable* fParent; @@ -41,9 +41,9 @@ private: class SkRoundRect : public SkDrawRect { DECLARE_MEMBER_INFO(RoundRect); SkRoundRect(); - virtual bool draw(SkAnimateMaker& ); + virtual bool draw(SkAnimateMaker& ) SK_OVERRIDE; #ifdef SK_DUMP_ENABLED - virtual void dump(SkAnimateMaker* ); + virtual void dump(SkAnimateMaker* ) SK_OVERRIDE; #endif protected: SkScalar rx; diff --git a/src/animator/SkDump.h b/src/animator/SkDump.h index 0a31b1c049..c2f6d2bf44 100644 --- a/src/animator/SkDump.h +++ b/src/animator/SkDump.h @@ -20,9 +20,9 @@ class SkDump : public SkDisplayable { DECLARE_MEMBER_INFO(Dump); #ifdef SK_DUMP_ENABLED SkDump(); - virtual bool enable(SkAnimateMaker & ); + virtual bool enable(SkAnimateMaker & ) SK_OVERRIDE; bool evaluate(SkAnimateMaker &); - virtual bool hasEnable() const; + virtual bool hasEnable() const SK_OVERRIDE; static void GetEnumString(SkDisplayTypes , int index, SkString* result); SkBool displayList; SkBool eventList; diff --git a/src/animator/SkMemberInfo.h b/src/animator/SkMemberInfo.h index a1b194118a..f005bab012 100644 --- a/src/animator/SkMemberInfo.h +++ b/src/animator/SkMemberInfo.h @@ -150,35 +150,35 @@ struct SkMemberInfo { public: \ static const SkMemberInfo fInfo[]; \ static const int fInfoCount; \ - virtual const SkMemberInfo* getMember(int index); \ - virtual const SkMemberInfo* getMember(const char name[]); \ + virtual const SkMemberInfo* getMember(int index) SK_OVERRIDE; \ + virtual const SkMemberInfo* getMember(const char name[]) SK_OVERRIDE; \ typedef Sk##_type BASE_CLASS #define DECLARE_MEMBER_INFO(_type) \ public: \ static const SkMemberInfo fInfo[]; \ static const int fInfoCount; \ - virtual const SkMemberInfo* getMember(int index); \ - virtual const SkMemberInfo* getMember(const char name[]); \ - virtual SkDisplayTypes getType() const { return SkType_##_type; } \ + virtual const SkMemberInfo* getMember(int index) SK_OVERRIDE; \ + virtual const SkMemberInfo* getMember(const char name[]) SK_OVERRIDE; \ + virtual SkDisplayTypes getType() const SK_OVERRIDE { return SkType_##_type; } \ typedef Sk##_type BASE_CLASS #define DECLARE_DRAW_MEMBER_INFO(_type) \ public: \ static const SkMemberInfo fInfo[]; \ static const int fInfoCount; \ - virtual const SkMemberInfo* getMember(int index); \ - virtual const SkMemberInfo* getMember(const char name[]); \ - virtual SkDisplayTypes getType() const { return SkType_##_type; } \ + virtual const SkMemberInfo* getMember(int index) SK_OVERRIDE; \ + virtual const SkMemberInfo* getMember(const char name[]) SK_OVERRIDE; \ + virtual SkDisplayTypes getType() const SK_OVERRIDE { return SkType_##_type; } \ typedef SkDraw##_type BASE_CLASS #define DECLARE_DISPLAY_MEMBER_INFO(_type) \ public: \ static const SkMemberInfo fInfo[]; \ static const int fInfoCount; \ - virtual const SkMemberInfo* getMember(int index); \ - virtual const SkMemberInfo* getMember(const char name[]); \ - virtual SkDisplayTypes getType() const { return SkType_##_type; } \ + virtual const SkMemberInfo* getMember(int index) SK_OVERRIDE; \ + virtual const SkMemberInfo* getMember(const char name[]) SK_OVERRIDE; \ + virtual SkDisplayTypes getType() const SK_OVERRIDE { return SkType_##_type; } \ typedef SkDisplay##_type BASE_CLASS #define DECLARE_EMPTY_MEMBER_INFO(_type) \ diff --git a/src/animator/SkPostParts.h b/src/animator/SkPostParts.h index 4101b2b2ee..7c1325826b 100644 --- a/src/animator/SkPostParts.h +++ b/src/animator/SkPostParts.h @@ -18,10 +18,10 @@ class SkDataInput: public SkInput { DECLARE_MEMBER_INFO(DataInput); SkDataInput(); bool add(); - virtual void dirty(); - virtual SkDisplayable* getParent() const; - virtual void onEndElement(SkAnimateMaker& ); - virtual bool setParent(SkDisplayable* ); + virtual void dirty() SK_OVERRIDE; + virtual SkDisplayable* getParent() const SK_OVERRIDE; + virtual void onEndElement(SkAnimateMaker& ) SK_OVERRIDE; + virtual bool setParent(SkDisplayable* ) SK_OVERRIDE; protected: SkPost* fParent; typedef SkInput INHERITED; diff --git a/src/pdf/SkPDFDeviceFlattener.h b/src/pdf/SkPDFDeviceFlattener.h index bb15237996..56f8da720a 100644 --- a/src/pdf/SkPDFDeviceFlattener.h +++ b/src/pdf/SkPDFDeviceFlattener.h @@ -30,7 +30,7 @@ public: virtual void drawPoints(const SkDraw&, SkCanvas::PointMode mode, size_t count, const SkPoint[], const SkPaint& paint) SK_OVERRIDE; - virtual void drawRect(const SkDraw&, const SkRect& r, const SkPaint& paint); + virtual void drawRect(const SkDraw&, const SkRect& r, const SkPaint& paint) SK_OVERRIDE; virtual void drawPath(const SkDraw&, const SkPath& origpath, const SkPaint& paint, const SkMatrix* prePathMatrix, bool pathIsMutable) SK_OVERRIDE; |