aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Leon Scroggins III <scroggo@google.com>2017-12-01 09:48:10 -0500
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2017-12-01 15:14:19 +0000
commit6d892f58bfd3ea0d48332e707a84734b70294c03 (patch)
tree1ec2a66bfd2335bb6ee335307d4fc313dc33b6c0
parentfa91627a758f413e33f7b17056b68271e3c0a4f8 (diff)
Add comments explaining use of "-Wno-over-aligned"
Follow up to I04a5b013dd0ec8f162046388e89cf08cb9476bab Change-Id: I5ab77564fe867ad1fef48fb322ff75869c025776 Reviewed-on: https://skia-review.googlesource.com/79040 Commit-Queue: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
-rw-r--r--gn/gn_to_bp.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/gn/gn_to_bp.py b/gn/gn_to_bp.py
index 7505d7247a..20260926a9 100644
--- a/gn/gn_to_bp.py
+++ b/gn/gn_to_bp.py
@@ -76,6 +76,10 @@ cc_library_static {
$x86_srcs
],
cflags: [
+ // Clang seems to think new/malloc will only be 4-byte aligned
+ // on x86 Android. We're pretty sure it's actually 8-byte
+ // alignment. tests/OverAlignedTest.cpp has more information,
+ // and should fail if we're wrong.
"-Wno-over-aligned"
],
},