aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Mike Reed <reed@google.com>2018-02-06 23:05:36 +0000
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2018-02-06 23:05:46 +0000
commit5dd202dc9002ec7b42279b85ff89ba4780ad394d (patch)
tree9aa3c46943f599d97380acb19a3129717084563d
parent7a316f6fe3ef0de49d65d51c259a44edae401ce5 (diff)
Revert "Revert "move GrColor.h to private, IWYU""
This reverts commit 63cc29304a65039feaf27842d587ed16de010b0d. Reason for revert: pdfium updated Original change's description: > Revert "move GrColor.h to private, IWYU" > > This reverts commit e602f395813aab8242afad356008b8e79911adbb. > > Reason for revert: Breaks PDFIUM > > Original change's description: > > move GrColor.h to private, IWYU > > > > Bug: skia: > > Change-Id: I0f0dabd7cc54cb7786f53bd6da0c0c012375037e > > Reviewed-on: https://skia-review.googlesource.com/104160 > > Commit-Queue: Mike Reed <reed@google.com> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > TBR=bsalomon@google.com,reed@google.com > > Change-Id: Ifaa50f8771fa1ca8bc152270efdb1fe27f7210f2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/104440 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,reed@google.com Change-Id: I22fa5c0e0628b5c1f3b5f13879c7d1a4528cc93a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/104561 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
-rw-r--r--gm/aaxfermodes.cpp3
-rw-r--r--gm/composeshader.cpp1
-rw-r--r--gm/filterbug.cpp1
-rw-r--r--gm/image.cpp1
-rw-r--r--gm/jpg_color_cube.cpp1
-rw-r--r--gm/shapes_as_paths.cpp1
-rw-r--r--gm/showmiplevels.cpp1
-rw-r--r--gm/simple_magnification.cpp1
-rw-r--r--gn/gpu.gni2
-rw-r--r--include/core/SkImage.h1
-rw-r--r--include/core/SkShader.h2
-rw-r--r--include/gpu/GrBlend.h2
-rw-r--r--include/gpu/GrContext.h1
-rw-r--r--include/private/GrColor.h (renamed from include/gpu/GrColor.h)0
-rw-r--r--src/core/SkPixmap.cpp1
-rw-r--r--src/core/SkUnPreMultiplyPriv.h1
-rw-r--r--src/effects/SkBlurMask.cpp1
-rw-r--r--src/effects/SkEmbossMaskFilter.cpp1
-rw-r--r--src/gpu/GrBlend.cpp1
-rw-r--r--tests/EncodeTest.cpp1
20 files changed, 19 insertions, 5 deletions
diff --git a/gm/aaxfermodes.cpp b/gm/aaxfermodes.cpp
index 1420e3d579..43b441c6cc 100644
--- a/gm/aaxfermodes.cpp
+++ b/gm/aaxfermodes.cpp
@@ -6,8 +6,9 @@
*/
#include "gm.h"
+#include "GrColor.h"
#include "sk_tool_utils.h"
-#include "SkBlendModePriv.h"
+#include "SkColorPriv.h"
#include "SkPath.h"
#include "SkShader.h"
diff --git a/gm/composeshader.cpp b/gm/composeshader.cpp
index ac5457faf4..8033ff739d 100644
--- a/gm/composeshader.cpp
+++ b/gm/composeshader.cpp
@@ -7,6 +7,7 @@
#include "gm.h"
+#include "SkColorPriv.h"
#include "SkCanvas.h"
#include "SkGradientShader.h"
#include "SkGraphics.h"
diff --git a/gm/filterbug.cpp b/gm/filterbug.cpp
index 181ba7c4e2..258374f73a 100644
--- a/gm/filterbug.cpp
+++ b/gm/filterbug.cpp
@@ -6,6 +6,7 @@
*/
#include "gm.h"
+#include "SkColorPriv.h"
#include "SkImageShader.h"
static const sk_sp<SkImage> make_image(int firstBlackRow, int lastBlackRow) {
diff --git a/gm/image.cpp b/gm/image.cpp
index e98daef42d..fc91d6b7f1 100644
--- a/gm/image.cpp
+++ b/gm/image.cpp
@@ -9,6 +9,7 @@
#include "gm.h"
#include "sk_tool_utils.h"
#include "SkAutoPixmapStorage.h"
+#include "SkColorPriv.h"
#include "SkData.h"
#include "SkCanvas.h"
#include "SkRandom.h"
diff --git a/gm/jpg_color_cube.cpp b/gm/jpg_color_cube.cpp
index 408cc90ea2..b083428345 100644
--- a/gm/jpg_color_cube.cpp
+++ b/gm/jpg_color_cube.cpp
@@ -7,6 +7,7 @@
#include "gm.h"
#include "sk_tool_utils.h"
#include "SkCanvas.h"
+#include "SkColorPriv.h"
#include "SkData.h"
#include "SkImage.h"
#include "SkImageEncoder.h"
diff --git a/gm/shapes_as_paths.cpp b/gm/shapes_as_paths.cpp
index 774ceed31d..4ad760dcc7 100644
--- a/gm/shapes_as_paths.cpp
+++ b/gm/shapes_as_paths.cpp
@@ -8,6 +8,7 @@
#include "gm.h"
#include "SkAutoPixmapStorage.h"
+#include "SkColorPriv.h"
#include "SkImage.h"
#include "SkPath.h"
#include "SkSurface.h"
diff --git a/gm/showmiplevels.cpp b/gm/showmiplevels.cpp
index 4f27365788..6f0975da7e 100644
--- a/gm/showmiplevels.cpp
+++ b/gm/showmiplevels.cpp
@@ -9,6 +9,7 @@
#include "sk_tool_utils.h"
#include "Resources.h"
+#include "SkColorPriv.h"
#include "SkGradientShader.h"
#include "SkTypeface.h"
#include "SkStream.h"
diff --git a/gm/simple_magnification.cpp b/gm/simple_magnification.cpp
index 14dade1307..ef5f9c6dd8 100644
--- a/gm/simple_magnification.cpp
+++ b/gm/simple_magnification.cpp
@@ -7,6 +7,7 @@
#include "gm.h"
#include "sk_tool_utils.h"
+#include "SkColorPriv.h"
#include "SkImageSource.h"
#include "SkMagnifierImageFilter.h"
#include "SkSurface.h"
diff --git a/gn/gpu.gni b/gn/gpu.gni
index 4d8f3d8973..8e6f76b653 100644
--- a/gn/gpu.gni
+++ b/gn/gpu.gni
@@ -12,7 +12,6 @@ skia_gpu_sources = [
"$_include/gpu/GrBackendSurface.h",
"$_include/gpu/GrBlend.h",
"$_include/gpu/GrCaps.h",
- "$_include/gpu/GrColor.h",
"$_include/gpu/GrConfig.h",
"$_include/gpu/GrContextOptions.h",
"$_include/gpu/GrContext.h",
@@ -34,6 +33,7 @@ skia_gpu_sources = [
# Private includes
"$_include/private/GrAuditTrail.h",
+ "$_include/private/GrColor.h",
"$_include/private/GrGLSL.h",
"$_include/private/GrOpList.h",
"$_include/private/GrSingleOwner.h",
diff --git a/include/core/SkImage.h b/include/core/SkImage.h
index deb0313faf..9e4e237db4 100644
--- a/include/core/SkImage.h
+++ b/include/core/SkImage.h
@@ -8,6 +8,7 @@
#ifndef SkImage_DEFINED
#define SkImage_DEFINED
+#include "GrTypes.h"
#include "SkFilterQuality.h"
#include "SkImageInfo.h"
#include "SkImageEncoder.h"
diff --git a/include/core/SkShader.h b/include/core/SkShader.h
index 290d09fc87..a5ba12ec2f 100644
--- a/include/core/SkShader.h
+++ b/include/core/SkShader.h
@@ -9,11 +9,11 @@
#define SkShader_DEFINED
#include "SkBlendMode.h"
+#include "SkColor.h"
#include "SkFilterQuality.h"
#include "SkFlattenable.h"
#include "SkImageInfo.h"
#include "SkMatrix.h"
-#include "../gpu/GrColor.h"
class SkArenaAlloc;
class SkBitmap;
diff --git a/include/gpu/GrBlend.h b/include/gpu/GrBlend.h
index 30b0b9b6e0..8c968f2d2e 100644
--- a/include/gpu/GrBlend.h
+++ b/include/gpu/GrBlend.h
@@ -9,7 +9,7 @@
#ifndef GrBlend_DEFINED
#define GrBlend_DEFINED
-#include "GrColor.h"
+#include "GrTypes.h"
#include "../private/SkTLogic.h"
/**
diff --git a/include/gpu/GrContext.h b/include/gpu/GrContext.h
index d0ca90e0f0..df9b85bacd 100644
--- a/include/gpu/GrContext.h
+++ b/include/gpu/GrContext.h
@@ -9,7 +9,6 @@
#define GrContext_DEFINED
#include "GrCaps.h"
-#include "GrColor.h"
#include "SkMatrix.h"
#include "SkPathEffect.h"
#include "SkTypes.h"
diff --git a/include/gpu/GrColor.h b/include/private/GrColor.h
index b4a461d738..b4a461d738 100644
--- a/include/gpu/GrColor.h
+++ b/include/private/GrColor.h
diff --git a/src/core/SkPixmap.cpp b/src/core/SkPixmap.cpp
index 7873a9b8ce..42e2c66029 100644
--- a/src/core/SkPixmap.cpp
+++ b/src/core/SkPixmap.cpp
@@ -19,6 +19,7 @@
#include "SkReadPixelsRec.h"
#include "SkSurface.h"
#include "SkTemplates.h"
+#include "SkUnPreMultiply.h"
#include "SkUtils.h"
/////////////////////////////////////////////////////////////////////////////////////////////////
diff --git a/src/core/SkUnPreMultiplyPriv.h b/src/core/SkUnPreMultiplyPriv.h
index 073e239ed7..f25e78f96a 100644
--- a/src/core/SkUnPreMultiplyPriv.h
+++ b/src/core/SkUnPreMultiplyPriv.h
@@ -9,6 +9,7 @@
#define SkUnPreMultiplyPriv_DEFINED
#include "SkColor.h"
+#include "SkUnPreMultiply.h"
template <bool kSwapRB>
void SkUnpremultiplyRow(uint32_t* dst, const uint32_t* src, int count) {
diff --git a/src/effects/SkBlurMask.cpp b/src/effects/SkBlurMask.cpp
index f06e2b9f1e..59d70205c9 100644
--- a/src/effects/SkBlurMask.cpp
+++ b/src/effects/SkBlurMask.cpp
@@ -7,6 +7,7 @@
#include "SkBlurMask.h"
+#include "SkColorPriv.h"
#include "SkMaskBlurFilter.h"
#include "SkMath.h"
#include "SkTemplates.h"
diff --git a/src/effects/SkEmbossMaskFilter.cpp b/src/effects/SkEmbossMaskFilter.cpp
index 4caef9ef0b..9fa26c5731 100644
--- a/src/effects/SkEmbossMaskFilter.cpp
+++ b/src/effects/SkEmbossMaskFilter.cpp
@@ -8,6 +8,7 @@
#include "SkEmbossMaskFilter.h"
#include "SkBlurMaskFilter.h"
#include "SkBlurMask.h"
+#include "SkColorPriv.h"
#include "SkEmbossMask.h"
#include "SkReadBuffer.h"
#include "SkWriteBuffer.h"
diff --git a/src/gpu/GrBlend.cpp b/src/gpu/GrBlend.cpp
index 1bb4dd3c9c..436829ce63 100644
--- a/src/gpu/GrBlend.cpp
+++ b/src/gpu/GrBlend.cpp
@@ -6,6 +6,7 @@
*/
#include "GrBlend.h"
+#include "../private/GrColor.h"
/**
* MaskedColor is used to evaluate the color and valid color component flags through the
diff --git a/tests/EncodeTest.cpp b/tests/EncodeTest.cpp
index 40e99565cb..8d5db7ddcd 100644
--- a/tests/EncodeTest.cpp
+++ b/tests/EncodeTest.cpp
@@ -9,6 +9,7 @@
#include "Test.h"
#include "SkBitmap.h"
+#include "SkColorPriv.h"
#include "SkEncodedImageFormat.h"
#include "SkImage.h"
#include "SkJpegEncoder.h"