diff options
author | rmistry <rmistry@google.com> | 2015-02-02 12:08:18 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-02-02 12:08:18 -0800 |
commit | 465206af184f58e8097e7f4f414b791232627c31 (patch) | |
tree | 683e180847663cc48cbddd624b2646587de317a5 | |
parent | 004a166ad79b86e790f27fdafc64aa71afdf0f82 (diff) |
Add missing SK_OVERRIDE
Tested by running on clang head + ubuntu 14.04:
GYP_DEFINES=”skia_gpu=0 skia_warnings_as_errors=1" tools/xsan_build thread dm BUILDTYPE=Release
out/Release/dm -v
BUG=skia:3386
Review URL: https://codereview.chromium.org/894833002
-rw-r--r-- | gm/cmykjpeg.cpp | 6 | ||||
-rw-r--r-- | gm/colorfilters.cpp | 4 | ||||
-rw-r--r-- | gm/colortypexfermode.cpp | 6 | ||||
-rwxr-xr-x | gm/dftext.cpp | 2 | ||||
-rw-r--r-- | gm/drawlooper.cpp | 2 | ||||
-rw-r--r-- | gm/factory.cpp | 6 | ||||
-rw-r--r-- | gm/hairmodes.cpp | 2 | ||||
-rw-r--r-- | gm/imagefilterscropped.cpp | 6 | ||||
-rw-r--r-- | src/ports/SkImageGenerator_skia.cpp | 4 | ||||
-rw-r--r-- | src/utils/debugger/SkDebugCanvas.cpp | 2 | ||||
-rw-r--r-- | tests/PDFPrimitivesTest.cpp | 2 | ||||
-rw-r--r-- | tests/PictureTest.cpp | 2 |
12 files changed, 22 insertions, 22 deletions
diff --git a/gm/cmykjpeg.cpp b/gm/cmykjpeg.cpp index 061c442334..75be712821 100644 --- a/gm/cmykjpeg.cpp +++ b/gm/cmykjpeg.cpp @@ -42,15 +42,15 @@ protected: } } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("cmykjpeg"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(640, 480); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { canvas->translate(20*SK_Scalar1, 20*SK_Scalar1); canvas->drawBitmap(fBitmap, 0, 0); diff --git a/gm/colorfilters.cpp b/gm/colorfilters.cpp index 9ecb56cd7e..20208066b2 100644 --- a/gm/colorfilters.cpp +++ b/gm/colorfilters.cpp @@ -41,11 +41,11 @@ public: } protected: - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return fName; } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(640, 480); } diff --git a/gm/colortypexfermode.cpp b/gm/colortypexfermode.cpp index 51cb7eb7c3..1b6e2894ae 100644 --- a/gm/colortypexfermode.cpp +++ b/gm/colortypexfermode.cpp @@ -54,15 +54,15 @@ public: } protected: - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("colortype_xfermodes"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(400, 640); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { canvas->translate(SkIntToScalar(10), SkIntToScalar(20)); const struct { diff --git a/gm/dftext.cpp b/gm/dftext.cpp index d6e19f67b5..6544e891c9 100755 --- a/gm/dftext.cpp +++ b/gm/dftext.cpp @@ -50,7 +50,7 @@ protected: canvas->translate(-px, -py); } - virtual void onDraw(SkCanvas* inputCanvas) { + virtual void onDraw(SkCanvas* inputCanvas) SK_OVERRIDE { #ifdef SK_BUILD_FOR_ANDROID SkScalar textSizes[] = { 9.0f, 9.0f*2.0f, 9.0f*5.0f, 9.0f*2.0f*5.0f }; #else diff --git a/gm/drawlooper.cpp b/gm/drawlooper.cpp index 1d16fb5955..56b412533a 100644 --- a/gm/drawlooper.cpp +++ b/gm/drawlooper.cpp @@ -27,7 +27,7 @@ public: } protected: - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(520, 160); } diff --git a/gm/factory.cpp b/gm/factory.cpp index 1e89d3df72..08701d3cfc 100644 --- a/gm/factory.cpp +++ b/gm/factory.cpp @@ -41,15 +41,15 @@ protected: } } - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("factory"); } - virtual SkISize onISize() { + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(640, 480); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { canvas->drawBitmap(fBitmap, 0, 0); } diff --git a/gm/hairmodes.cpp b/gm/hairmodes.cpp index 82a55ea193..aa1af0335c 100644 --- a/gm/hairmodes.cpp +++ b/gm/hairmodes.cpp @@ -82,7 +82,7 @@ namespace skiagm { return SkString("hairmodes"); } - virtual SkISize onISize() { return SkISize::Make(640, 480); } + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(640, 480); } void onOnceBeforeDraw() SK_OVERRIDE { fBGPaint.setShader(make_bg_shader())->unref(); diff --git a/gm/imagefilterscropped.cpp b/gm/imagefilterscropped.cpp index 86dfbcb2df..3db0b123c8 100644 --- a/gm/imagefilterscropped.cpp +++ b/gm/imagefilterscropped.cpp @@ -96,11 +96,11 @@ public: ImageFiltersCroppedGM () {} protected: - virtual SkString onShortName() { + virtual SkString onShortName() SK_OVERRIDE { return SkString("imagefilterscropped"); } - virtual SkISize onISize() { return SkISize::Make(400, 880); } + virtual SkISize onISize() SK_OVERRIDE { return SkISize::Make(400, 880); } void make_checkerboard() { fCheckerboard.allocN32Pixels(80, 80); @@ -134,7 +134,7 @@ protected: make_checkerboard(); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { void (*drawProc[])(SkCanvas*, const SkRect&, SkImageFilter*) = { draw_sprite, draw_bitmap, draw_path, draw_paint, draw_text }; diff --git a/src/ports/SkImageGenerator_skia.cpp b/src/ports/SkImageGenerator_skia.cpp index cd02ae2567..878a44de9c 100644 --- a/src/ports/SkImageGenerator_skia.cpp +++ b/src/ports/SkImageGenerator_skia.cpp @@ -47,13 +47,13 @@ protected: return SkRef(fData.get()); } - virtual bool onGetInfo(SkImageInfo* info) { + virtual bool onGetInfo(SkImageInfo* info) SK_OVERRIDE { *info = fInfo; return true; } virtual bool onGetPixels(const SkImageInfo& info, void* pixels, size_t rowBytes, - SkPMColor ctableEntries[], int* ctableCount) { + SkPMColor ctableEntries[], int* ctableCount) SK_OVERRIDE { SkMemoryStream stream(fData->data(), fData->size(), false); SkAutoTUnref<BareMemoryAllocator> allocator(SkNEW_ARGS(BareMemoryAllocator, (info, pixels, rowBytes))); diff --git a/src/utils/debugger/SkDebugCanvas.cpp b/src/utils/debugger/SkDebugCanvas.cpp index 9d809559dc..337c9d0d65 100644 --- a/src/utils/debugger/SkDebugCanvas.cpp +++ b/src/utils/debugger/SkDebugCanvas.cpp @@ -117,7 +117,7 @@ public: Factory getFactory() const SK_OVERRIDE { return NULL; } #ifndef SK_IGNORE_TO_STRING - virtual void toString(SkString* str) const { str->set("OverdrawXfermode"); } + virtual void toString(SkString* str) const SK_OVERRIDE { str->set("OverdrawXfermode"); } #endif }; diff --git a/tests/PDFPrimitivesTest.cpp b/tests/PDFPrimitivesTest.cpp index f15f06090d..8b1ebe0051 100644 --- a/tests/PDFPrimitivesTest.cpp +++ b/tests/PDFPrimitivesTest.cpp @@ -466,7 +466,7 @@ public: DummyImageFilter(bool visited = false) : SkImageFilter(0, NULL), fVisited(visited) {} ~DummyImageFilter() SK_OVERRIDE {} virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&, - SkBitmap* result, SkIPoint* offset) const { + SkBitmap* result, SkIPoint* offset) const SK_OVERRIDE { fVisited = true; offset->fX = offset->fY = 0; *result = src; diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp index c9860f994c..18af979954 100644 --- a/tests/PictureTest.cpp +++ b/tests/PictureTest.cpp @@ -1256,7 +1256,7 @@ struct CountingBBH : public SkBBoxHierarchy { } void insert(SkAutoTMalloc<SkRect>*, int) SK_OVERRIDE {} - virtual size_t bytesUsed() const { return 0; } + virtual size_t bytesUsed() const SK_OVERRIDE { return 0; } }; class SpoonFedBBHFactory : public SkBBHFactory { |