diff options
| author |  hcm <hcm@google.com> | 2016-01-19 13:57:27 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-01-19 13:57:27 -0800 |
| commit | 4020665b81e0ff58b317c685056faa071b823b5a (patch) | |
| tree | 7d2c788cd2bfc551e6f42cf7d57532160b0b5d8e | |
| parent | f2e2ad047960f3d4144b3e298ded76c46f3e3092 (diff) | |
Fix patch check-in instructions for non-committers
BUG=skia:4681
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606003003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1606003003
Review URL: https://codereview.chromium.org/1606003003
| -rw-r--r-- | site/dev/contrib/submit.md | 42 |
1 files changed, 21 insertions, 21 deletions
diff --git a/site/dev/contrib/submit.md b/site/dev/contrib/submit.md index 1260f0582b..12adf51958 100644 --- a/site/dev/contrib/submit.md +++ b/site/dev/contrib/submit.md @@ -199,27 +199,27 @@ commit your change directly to Skia's repository. If you don't have committer rights in https://skia.googlesource.com/skia.git ... first of all, thanks for submitting your patch! We really appreciate these -submissions. Unfortunately, we don't yet have a way for Skia committers to mark -a patch as "approved" and thus allow non-committers to commit them. So instead, -please ask a Skia committer to land your patch for you or land using the commit -queue. - -As part of this process, the Skia committer may create a new codereview -containing your patch (perhaps with some small adjustments at her discretion). -If so, you can mark your codereview as "Closed", and update it with a link to -the new codereview. - -### Skia committers: - * tips on how to apply the externally provided patch are [here](./patch) +submissions. After receiving an LGTM from a committer, you will be able to +check the commit box and submit your patch via the commit queue. + +In special instances, a Skia committer may assist you in landing the change by +creating a new codereview containing your patch (perhaps with some small +adjustments at his/her discretion). If so, you can mark your codereview as +"Closed", and update it with a link to the new codereview. + +### Skia committers + * tips on how to apply an externally provided patch are [here](./patch) * when landing externally contributed patches, please note the original contributor's identity (and provide a link to the original codereview) in the commit message -git-cl will squash all your commits into a single one with the description you used when you uploaded your change. - -~~~~ -git cl land -~~~~ -or -~~~~ -git cl land -c 'Contributor Name <email@example.com>' -~~~~ + git-cl will squash all your commits into a single one with the description you used when you uploaded your change. + + ~~~~ + git cl land + ~~~~ + + or + + ~~~~ + git cl land -c 'Contributor Name <email@example.com>' + ~~~~ |