aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar sugoi <sugoi@chromium.org>2014-10-09 11:35:09 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2014-10-09 11:35:09 -0700
commit12b1831ea49f3d88e93b7d2793d94852d03813e8 (patch)
tree8b94e6d1d1e09eb4ac5f582ac1769871dbcbcd88
parent8db6f23d9074da6dc8a3fa4114d13c835ff5e19c (diff)
Attempt at fixing color cube bench
The original bench was hitting the cache since it was using the same color filter for all loops. By creating a new color filter within the loop, at least this part of it is solved. I'm not 100% sure this is the right way, but at least the numbers are a bit more reasonable and are affected by the output resolution. BUG=skia: Review URL: https://codereview.chromium.org/648483002
-rw-r--r--bench/ColorCubeBench.cpp7
1 files changed, 3 insertions, 4 deletions
diff --git a/bench/ColorCubeBench.cpp b/bench/ColorCubeBench.cpp
index 16ed4ce892..141edf62a4 100644
--- a/bench/ColorCubeBench.cpp
+++ b/bench/ColorCubeBench.cpp
@@ -94,12 +94,11 @@ private:
}
void test(const int loops, SkCanvas* canvas) {
- SkAutoTUnref<SkColorFilter> colorCube(
- SkColorCubeFilter::Create(fCubeData, fCubeDimension));
SkPaint paint;
- paint.setColorFilter(colorCube);
-
for (int i = 0; i < loops; i++) {
+ SkAutoTUnref<SkColorFilter> colorCube(
+ SkColorCubeFilter::Create(fCubeData, fCubeDimension));
+ paint.setColorFilter(colorCube);
canvas->drawBitmap(fBitmap, 0, 0, &paint);
}
}