diff options
| author |  mtklein <mtklein@chromium.org> | 2016-03-28 12:43:39 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-03-28 12:43:39 -0700 |
| commit | 02b2f1900db8e20daf22a2c9972311308d259426 (patch) | |
| tree | 329133443a68a49dd22b379bd599c1d09bc6b237 | |
| parent | af132770a9462f6bb9cff47254e44675d9241fe8 (diff) | |
We meant these to be YES... sigh.
This will dramatically improve link times with XCode 7.3.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1835303003
Review URL: https://codereview.chromium.org/1835303003
| -rw-r--r-- | gyp/common_conditions.gypi | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi index bfdbb9e29b..1485606f1b 100644 --- a/gyp/common_conditions.gypi +++ b/gyp/common_conditions.gypi @@ -542,8 +542,8 @@ 'GCC_ENABLE_CPP_RTTI': 'NO', # -fno-rtti 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics 'GCC_ENABLE_SUPPLEMENTAL_SSE3_INSTRUCTIONS': 'YES', # -mssse3 - 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', # -fvisibility=hidden - 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'NO', # -fvisibility-inlines-hidden + 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden + 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES', # -fvisibility-inlines-hidden 'GCC_CW_ASM_SYNTAX': 'NO', # remove -fasm-blocks 'GCC_ENABLE_PASCAL_STRINGS': 'NO', # remove -mpascal-strings 'WARNING_CFLAGS': [ @@ -598,8 +598,8 @@ 'GCC_ENABLE_CPP_EXCEPTIONS': 'NO', # -fno-exceptions 'GCC_ENABLE_CPP_RTTI': 'NO', # -fno-rtti 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics - 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', # -fvisibility=hidden - 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'NO', # -fvisibility-inlines-hidden + 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden + 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES', # -fvisibility-inlines-hidden 'GCC_THUMB_SUPPORT': 'NO', # TODO(mtklein): why would we not want thumb? }, |