diff options
| author |  Brent Shaffer <betterbrent@google.com> | 2017-07-17 09:14:46 -0700 |
|---|---|---|
| committer |  Paul Yang <TeBoring@users.noreply.github.com> | 2017-07-17 09:14:46 -0700 |
| commit | 324b20a49170cb38d15ef243bc044026adb54ae1 (patch) | |
| tree | 7b2e7a82b26d6246d48e15b2d32e37c64ecefef9 /src/google/protobuf/compiler/php | |
| parent | 29ff49f5345693bd04aa37654aa002054d1b9780 (diff) | |
remove pass by reference for php setters (#3344)
* remove pass by reference for php setters
* comments out memory leak test
Diffstat (limited to 'src/google/protobuf/compiler/php')
| -rw-r--r-- | src/google/protobuf/compiler/php/php_generator.cc | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/google/protobuf/compiler/php/php_generator.cc b/src/google/protobuf/compiler/php/php_generator.cc index e20b89ae..17d8ebad 100644 --- a/src/google/protobuf/compiler/php/php_generator.cc +++ b/src/google/protobuf/compiler/php/php_generator.cc @@ -534,12 +534,9 @@ void GenerateFieldAccessor(const FieldDescriptor* field, bool is_descriptor, // Generate setter. GenerateFieldDocComment(printer, field, is_descriptor, kFieldSetter); printer->Print( - "public function set^camel_name^(^var^)\n" + "public function set^camel_name^($var)\n" "{\n", - "camel_name", UnderscoresToCamelCase(field->name(), true), - "var", (field->is_repeated() || - field->cpp_type() == FieldDescriptor::CPPTYPE_MESSAGE) ? - "&$var": "$var"); + "camel_name", UnderscoresToCamelCase(field->name(), true)); Indent(printer); |