aboutsummaryrefslogtreecommitdiffhomepage
path: root/ruby
diff options
context:
space:
mode:
authorGravatar Andreas Eger <dev@eger-andreas.de>2016-12-11 03:30:08 +0100
committerGravatar Andreas Eger <dev@eger-andreas.de>2017-05-13 21:38:15 +0200
commitad203bcb2be17e06909ab6d67ab2475673673bbc (patch)
tree337493888b00b12e03ca6050808cf62d51d2eda0 /ruby
parent455b61c6b0f39ac269b26969877dd3c6f3e32270 (diff)
fix floating point accuracy problem in Timestamp#to_f
`.quo` return the most exact devision which fixes accuracy problems for the timestamp coercion
Diffstat (limited to 'ruby')
-rw-r--r--ruby/lib/google/protobuf/well_known_types.rb2
-rw-r--r--ruby/tests/well_known_types_test.rb9
2 files changed, 8 insertions, 3 deletions
diff --git a/ruby/lib/google/protobuf/well_known_types.rb b/ruby/lib/google/protobuf/well_known_types.rb
index 547de874..921ddbc0 100644
--- a/ruby/lib/google/protobuf/well_known_types.rb
+++ b/ruby/lib/google/protobuf/well_known_types.rb
@@ -80,7 +80,7 @@ module Google
end
def to_f
- self.seconds + (self.nanos.to_f / 1_000_000_000)
+ self.seconds + (self.nanos.quo(1_000_000_000))
end
end
diff --git a/ruby/tests/well_known_types_test.rb b/ruby/tests/well_known_types_test.rb
index 9b46632b..ad8531d9 100644
--- a/ruby/tests/well_known_types_test.rb
+++ b/ruby/tests/well_known_types_test.rb
@@ -13,10 +13,15 @@ class TestWellKnownTypes < Test::Unit::TestCase
assert_equal Time.at(12345), ts.to_time
assert_equal 12345, ts.to_i
- ts.from_time(Time.at(123456, 654321))
+ time = Time.at(123456, 654321)
+ ts.from_time(time)
assert_equal 123456, ts.seconds
assert_equal 654321000, ts.nanos
- assert_equal Time.at(123456.654321), ts.to_time
+ assert_equal time, ts.to_time
+
+ time = Time.now
+ ts.from_time(time)
+ assert_equal time.to_f, ts.to_time.to_f
end
def test_duration