aboutsummaryrefslogtreecommitdiffhomepage
path: root/ruby/ext
diff options
context:
space:
mode:
authorGravatar Ewout <e@ewout.name>2018-02-20 16:58:58 +0100
committerGravatar Ewout <e@ewout.name>2018-02-20 17:13:21 +0100
commit7b8f571756792ed2296a766c70af4ddf69082099 (patch)
treed53cd8664d01d386babc863ff2d2fc62d93a1570 /ruby/ext
parente34ec6077af141dd5dfc1c334ecdcce3c6b51612 (diff)
Ruby JSON encoding omits zero-length repeated fields by default.
This makes it behave the same way as the other implementations. It is also nice to always encode an empty message as {}.
Diffstat (limited to 'ruby/ext')
-rw-r--r--ruby/ext/google/protobuf_c/encode_decode.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/ruby/ext/google/protobuf_c/encode_decode.c b/ruby/ext/google/protobuf_c/encode_decode.c
index 12080d03..8c6ded64 100644
--- a/ruby/ext/google/protobuf_c/encode_decode.c
+++ b/ruby/ext/google/protobuf_c/encode_decode.c
@@ -963,13 +963,15 @@ static void putary(VALUE ary, const upb_fielddef *f, upb_sink *sink,
if (ary == Qnil) return;
+ size = NUM2INT(RepeatedField_length(ary));
+ if (size == 0 && !emit_defaults) return;
+
upb_sink_startseq(sink, getsel(f, UPB_HANDLER_STARTSEQ), &subsink);
if (upb_fielddef_isprimitive(f)) {
sel = getsel(f, upb_handlers_getprimitivehandlertype(f));
}
- size = NUM2INT(RepeatedField_length(ary));
for (int i = 0; i < size; i++) {
void* memory = RepeatedField_index_native(ary, i);
switch (type) {