aboutsummaryrefslogtreecommitdiffhomepage
path: root/php/tests/proto
diff options
context:
space:
mode:
authorGravatar Paul Yang <TeBoring@users.noreply.github.com>2017-07-14 15:48:48 -0600
committerGravatar GitHub <noreply@github.com>2017-07-14 15:48:48 -0600
commitc78dbd7c895b8c80cd2f2401d73acf890edf82c6 (patch)
tree98c59f78325ec539b843505a7e9389be97dc6035 /php/tests/proto
parentec3f5dcc725c415cf6bbc8325adf731370a3507d (diff)
Initial value in generated code cannot be used by c extension. (#3367)
In the generated code of previous versions, each php field is given an initial value. In c extension, it was assumed that the field order in the generated code is consistent with upb fields order, so that the correct initial value can be bound to the correct upb field. However, this may not be true. The order of fields in generated code is decided by proto compiler, while the order of upb fields is decided by the hash function used in c extension. This PR fixes the issue by reset the initial value at runtime.
Diffstat (limited to 'php/tests/proto')
-rw-r--r--php/tests/proto/test.proto6
1 files changed, 6 insertions, 0 deletions
diff --git a/php/tests/proto/test.proto b/php/tests/proto/test.proto
index dada8b48..d81f66f5 100644
--- a/php/tests/proto/test.proto
+++ b/php/tests/proto/test.proto
@@ -181,3 +181,9 @@ message TestIncludeNamespaceMessage {
TestNamespace namespace_message = 1;
TestEmptyNamespace empty_namespace_message = 2;
}
+
+// This will cause upb fields not ordered by the order in the generated code.
+message TestRandomFieldOrder {
+ int64 tag13 = 150;
+ string tag14 = 160;
+}