aboutsummaryrefslogtreecommitdiffhomepage
path: root/php/tests/proto
diff options
context:
space:
mode:
authorGravatar Paul Yang <TeBoring@users.noreply.github.com>2017-08-04 16:35:49 -0700
committerGravatar GitHub <noreply@github.com>2017-08-04 16:35:49 -0700
commit49b44bff2b6257a119f9c6a342d6151c736586b8 (patch)
tree75fbf8e5e5b9645c1108b321cd803b697fda0b34 /php/tests/proto
parent21b0e5587c01948927ede9be789671ff116b7ad4 (diff)
Fix the bug in php c extension that setting one field can change another field's value. (#3455)
* Fix the bug in php c extension that setting one field can change another field's value. The reason is that previously, in c extension, it was assumed that the order that fields were declared in php is the same as the order of fields in upb. This is not true. Now, for every field in upb, we will look up the actual property that is corresponding to the upb field. * Cleanup pull request * Fix indentation * Port to php5 * Port with php7.1 * Port to zts
Diffstat (limited to 'php/tests/proto')
-rw-r--r--php/tests/proto/test.proto5
1 files changed, 5 insertions, 0 deletions
diff --git a/php/tests/proto/test.proto b/php/tests/proto/test.proto
index d81f66f5..a90f3d1d 100644
--- a/php/tests/proto/test.proto
+++ b/php/tests/proto/test.proto
@@ -187,3 +187,8 @@ message TestRandomFieldOrder {
int64 tag13 = 150;
string tag14 = 160;
}
+
+message TestReverseFieldOrder {
+ repeated int32 a = 2;
+ string b = 1;
+}