diff options
| author |  Paul Yang <TeBoring@users.noreply.github.com> | 2017-04-20 16:55:56 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2017-04-20 16:55:56 -0700 |
| commit | 4523c9c233dbb61d03996a5bbe25d1b5aea51f7f (patch) | |
| tree | bebedd58dac1966bc462c00dfc39b1fea5deb6c6 /php/src/Google/Protobuf | |
| parent | 4c57e8475f78ccac80407f03c2d23d30014785f9 (diff) | |
Allow proto files to import descriptor.proto (#2995)
descriptor.proto uses proto2 syntax, which is not ready for external
usage. However, some proto3 files import descriptor.proto and cannot be
used. In this PR, all references (We cheated by only removing
extensions, which is enough for now. User should avoid using messages
defined in descriptor.proto as field type.) to content in
descriptor.proto are removed from generated files. Those that import
descriptor.proto can be used like other proto files.
Diffstat (limited to 'php/src/Google/Protobuf')
| -rw-r--r-- | php/src/Google/Protobuf/Internal/MapField.php | 1 | ||||
| -rw-r--r-- | php/src/Google/Protobuf/Internal/Message.php | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/php/src/Google/Protobuf/Internal/MapField.php b/php/src/Google/Protobuf/Internal/MapField.php index f65bd9b8..55cc12ce 100644 --- a/php/src/Google/Protobuf/Internal/MapField.php +++ b/php/src/Google/Protobuf/Internal/MapField.php @@ -155,7 +155,6 @@ function checkKey($key_type, &$key) GPBUtil::checkString($key, true); break; default: - var_dump($key_type); trigger_error( "Given type cannot be map key.", E_USER_ERROR); diff --git a/php/src/Google/Protobuf/Internal/Message.php b/php/src/Google/Protobuf/Internal/Message.php index 0fb6cdc0..887c86ca 100644 --- a/php/src/Google/Protobuf/Internal/Message.php +++ b/php/src/Google/Protobuf/Internal/Message.php @@ -71,7 +71,6 @@ class Message return; } $pool = DescriptorPool::getGeneratedPool(); - var_dump(get_class($this)); $this->desc = $pool->getDescriptorByClassName(get_class($this)); foreach ($this->desc->getField() as $field) { $setter = $field->getSetter(); |