aboutsummaryrefslogtreecommitdiffhomepage
path: root/conformance
diff options
context:
space:
mode:
authorGravatar Thomas Van Lenten <thomasvl@google.com>2017-07-26 16:24:05 -0400
committerGravatar Thomas Van Lenten <thomasvl@google.com>2017-07-26 16:24:05 -0400
commit3caf9fd00a84d71c63c9fb873eb9befd70400153 (patch)
tree79fd3e64c0c103f780156fe3988e61a83c75edcc /conformance
parentc2831a346c02678c751cdb8fb98387c773dc08a4 (diff)
Review feedback.
- Better error message for unknown messageType. - Remove unneeded if.
Diffstat (limited to 'conformance')
-rw-r--r--conformance/conformance_objc.m14
1 files changed, 6 insertions, 8 deletions
diff --git a/conformance/conformance_objc.m b/conformance/conformance_objc.m
index 6023fc78..84a43811 100644
--- a/conformance/conformance_objc.m
+++ b/conformance/conformance_objc.m
@@ -78,15 +78,13 @@ static ConformanceResponse *DoTest(ConformanceRequest *request) {
} else if ([request.messageType isEqual:@"protobuf_test_messages.proto2.TestAllTypesProto2"]) {
msgClass = [TestAllTypesProto2 class];
} else {
- Die(@"Protobuf request doesn't have specific payload type");
+ Die(@"Protobuf request had an unknown message_type: %@", request.messageType);
}
- if (msgClass) {
- NSError *error = nil;
- testMessage = [msgClass parseFromData:request.protobufPayload error:&error];
- if (!testMessage) {
- response.parseError =
- [NSString stringWithFormat:@"Parse error: %@", error];
- }
+ NSError *error = nil;
+ testMessage = [msgClass parseFromData:request.protobufPayload error:&error];
+ if (!testMessage) {
+ response.parseError =
+ [NSString stringWithFormat:@"Parse error: %@", error];
}
break;
}