aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Sergio Campamá <kaipi@google.com>2017-03-01 11:00:56 -0800
committerGravatar Thomas Van Lenten <thomasvl@google.com>2017-03-01 14:00:56 -0500
commit8b182cc45575117d19f0695cbde80f6e43b722d5 (patch)
tree57071e359913ace3a6b8fdbbdc2b1ffe0d7d59ec
parent6011d7ca4c3207661ca247be4a39f861d93b8065 (diff)
Disable static analyzer for message semaphore creation (#2748)
Disable static analyzer for message semaphore creation
-rw-r--r--objectivec/GPBMessage_PackagePrivate.h8
1 files changed, 8 insertions, 0 deletions
diff --git a/objectivec/GPBMessage_PackagePrivate.h b/objectivec/GPBMessage_PackagePrivate.h
index 02d0e16e..9324cf8d 100644
--- a/objectivec/GPBMessage_PackagePrivate.h
+++ b/objectivec/GPBMessage_PackagePrivate.h
@@ -108,9 +108,17 @@ CF_EXTERN_C_BEGIN
NS_INLINE void GPBPrepareReadOnlySemaphore(GPBMessage *self) {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdirect-ivar-access"
+
+// Starting on Xcode 8.3, the static analyzer complains that the dispatch_once_t
+// variable passed to dispatch_once should not be allocated on the heap or
+// stack. Given that the semaphore is also an instance variable of the message,
+// both variables are cleared at the same time, so this is safe.
+#if !defined(__clang_analyzer__)
dispatch_once(&self->readOnlySemaphoreCreationOnce_, ^{
self->readOnlySemaphore_ = dispatch_semaphore_create(1);
});
+#endif // !defined(__clang_analyzer__)
+
#pragma clang diagnostic pop
}