diff options
| author |  Harvey Tuch <htuch@google.com> | 2018-06-21 15:31:18 -0400 |
|---|---|---|
| committer | Harvey Tuch <htuch@google.com> | 2018-06-21 15:31:18 -0400 |
| commit | 395ae4f7adb667917a01c875c526f9d878aeb4aa (patch) | |
| tree | 9c6b0980e7518a07b52b6ffcec239c35682e3b5b | |
| parent | 0584084b7ed29db8fcc78211ca7d12d77b95f302 (diff) | |
Added TODO for grouping options.
Signed-off-by: Harvey Tuch <htuch@google.com>
| -rw-r--r-- | src/google/protobuf/util/internal/protostream_objectsource.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/google/protobuf/util/internal/protostream_objectsource.cc b/src/google/protobuf/util/internal/protostream_objectsource.cc index ef5dea07..b0d86c17 100644 --- a/src/google/protobuf/util/internal/protostream_objectsource.cc +++ b/src/google/protobuf/util/internal/protostream_objectsource.cc @@ -648,6 +648,9 @@ Status ProtoStreamObjectSource::RenderAny(const ProtoStreamObjectSource* os, // using a nested ProtoStreamObjectSource using our nested type information. ProtoStreamObjectSource nested_os(&in_stream, os->typeinfo_, *nested_type); + // TODO(htuch): This is somewhat fragile, since new options may be omitted. + // We should probably do this via the constructor or some object grouping + // options. nested_os.set_use_lower_camel_for_enums(os->use_lower_camel_for_enums_); nested_os.set_use_ints_for_enums(os->use_ints_for_enums_); nested_os.set_preserve_proto_field_names(os->preserve_proto_field_names_); |