diff options
| author |  jonathanmetzman <31354670+jonathanmetzman@users.noreply.github.com> | 2021-10-31 20:36:07 -0400 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2021-10-31 20:36:07 -0400 |
| commit | 4ce563f882b41c658621a9a57737aeb8ff849510 (patch) | |
| tree | 47ae3178b2bfd6e48617b008b7f008401c0d426c /infra/cifuzz/build_fuzzers.py | |
| parent | 4fd64a37929bcef07dd9410e88e6d0651c83f45c (diff) | |
Fix diffing on non-GitHub and improve config (#6707)
Fix diffing on non-GitHub and improve config
1. Remove obsolete comments.
2. Remove unused function get_pr_ref
3. Correct comment on git_sha
4. Rename commit_sha to git_sha
5. Make base_commit, pr_ref, and base_ref non-github specific and move to
CiEnvironment.
6. Hoist get_diff_base to base class to allow diffing
7. Fix downloading coverage on non-Github.
8. Add TODO so that we don't assume github actions is run on github.com
(enterprise users)
9. Rename repo_url to git_url.
10. Add missing git_url method base class.
11. Clarify what git_url, git_sha and pr_ref are for and leave TODOs about how
we can eliminate them.
12. Fix typos.
Diffstat (limited to 'infra/cifuzz/build_fuzzers.py')
| -rw-r--r-- | infra/cifuzz/build_fuzzers.py | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/infra/cifuzz/build_fuzzers.py b/infra/cifuzz/build_fuzzers.py index 58f60f7d..c35115c4 100644 --- a/infra/cifuzz/build_fuzzers.py +++ b/infra/cifuzz/build_fuzzers.py @@ -154,16 +154,10 @@ def build_fuzzers(config): """Builds all of the fuzzers for a specific OSS-Fuzz project. Args: - project_name: The name of the OSS-Fuzz project being built. - project_repo_name: The name of the project's repo. - workspace: The location in a shared volume to store a git repo and build - artifacts. - pr_ref: The pull request reference to be built. - commit_sha: The commit sha for the project to be built at. - sanitizer: The sanitizer the fuzzers should be built with. + config: The configuration object for building fuzzers. Returns: - True if build succeeded or False on failure. + True if build succeeded. """ # Do some quick validation. if config.project_src_path and not check_project_src_path( |