aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/base-images
diff options
context:
space:
mode:
authorGravatar Evgeny Vereshchagin <evvers@ya.ru>2019-05-15 16:38:09 +0300
committerGravatar Max Moroz <mmoroz@chromium.org>2019-05-15 06:38:09 -0700
commit2361c62433d840ed2a85821deed7fd766f099948 (patch)
treeb5d16518bc5fbefc80609eccef42f463093f03ae /infra/base-images
parent8f9a3fa22ba404a8a6e25ecb0315880a6cf52724 (diff)
[infra] make it possible to override the percentage of targets that can be broken (#2419)
10% is an absolutely sensible default in general especially for single-purpose libraries like json-parsers. When large "umbrella" projects (like systemd) are fuzzed with 30 fuzzers (and counting (hopefully :-)) covering code scattered all over their repositories it's too easy to introduce a broken fuzzer or break a couple of fuzzers accidentally even after running `check_build`. Waiting for two to three days for ClusterFuzz to open an issue isn't ideal from the point of view of large open-source project maintainers (where generally contributors come and go) so one solution would be to run something like when PRs are opened ```sh helper.py check_build ALLOWED_BROKEN_TARGETS_PERCENTAGE=0 ... ``` and catch issues as early as possible (and fix them while the context isn't completely faded away). I also considered changing this with `sed` and rebuilding `base-images/base-runner` locally but it takes too much time, looks too kludgy (even to me) and is likely to be broken in a week or so :-)
Diffstat (limited to 'infra/base-images')
-rwxr-xr-xinfra/base-images/base-runner/test_all2
1 files changed, 1 insertions, 1 deletions
diff --git a/infra/base-images/base-runner/test_all b/infra/base-images/base-runner/test_all
index 2d5600e2..556591ed 100755
--- a/infra/base-images/base-runner/test_all
+++ b/infra/base-images/base-runner/test_all
@@ -16,7 +16,7 @@
################################################################################
# Percentage threshold that needs to be reached for marking a build as failed.
-ALLOWED_BROKEN_TARGETS_PERCENTAGE=10
+ALLOWED_BROKEN_TARGETS_PERCENTAGE=${ALLOWED_BROKEN_TARGETS_PERCENTAGE:-10}
# Test all fuzz targets in the $OUT/ dir.
TOTAL_TARGETS_COUNT=0