aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Oliver Chang <oliverchang@users.noreply.github.com>2022-07-05 15:38:21 +1000
committerGravatar GitHub <noreply@github.com>2022-07-05 05:38:21 +0000
commit9665b2e1b8d73ce887603991fd7dc8a9c0cd50ac (patch)
treea56e3499319d65e4c304741f3d241b2b34d7e5dd
parent31bd0caf71b8bad1f2122c8c5cebc62d404914b3 (diff)
execSan: Don't exit on reporting a bug. (#7947)
This causes race conditions with stacktrace printing and does not return the same exit code as the child process. Just send the SIGABRT and let our tracing handle the exit.
-rw-r--r--infra/experimental/sanitizers/ExecSan/execSan.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/infra/experimental/sanitizers/ExecSan/execSan.cpp b/infra/experimental/sanitizers/ExecSan/execSan.cpp
index 15c1cc1b..f36a2184 100644
--- a/infra/experimental/sanitizers/ExecSan/execSan.cpp
+++ b/infra/experimental/sanitizers/ExecSan/execSan.cpp
@@ -178,7 +178,6 @@ void report_bug(std::string bug_type) {
// Note: this may not be reliable or consistent if shell injection happens
// in an async way.
kill(g_root_pid, SIGABRT);
- _exit(0);
}
void inspect_for_injection(pid_t pid, const user_regs_struct &regs) {