aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar jonathanmetzman <31354670+jonathanmetzman@users.noreply.github.com>2022-07-07 13:38:33 +0200
committerGravatar GitHub <noreply@github.com>2022-07-07 13:38:33 +0200
commit02659954bea618ae269bb9d554e2283f94650cf8 (patch)
tree2077a3b0d7d66db55b5b34dc30c44f449508fa74
parentb595703133394fff7eb61d1fa3f0ad0f366c283f (diff)
Get rid of dataflow check in presubmit.py (#7967)
Get rid of datalow check in presubmit.py Related: #7964
-rwxr-xr-xinfra/presubmit.py20
1 files changed, 0 insertions, 20 deletions
diff --git a/infra/presubmit.py b/infra/presubmit.py
index 74a00167..0eb8efe2 100755
--- a/infra/presubmit.py
+++ b/infra/presubmit.py
@@ -123,7 +123,6 @@ class ProjectYamlChecker:
self.check_valid_section_names,
self.check_valid_emails,
self.check_valid_language,
- self.check_dataflow,
]
for check_function in checks:
check_function()
@@ -139,25 +138,6 @@ class ProjectYamlChecker:
print('Error in {filename}: {message}'.format(filename=self.filename,
message=message))
- def check_dataflow(self):
- """Checks that if "dataflow" is specified in "fuzzing_engines", it is also
- specified in "sanitizers", and that if specified in "sanitizers", it is also
- specified in "fuzzing_engines". Returns True if this condition is met."""
- engines = self.data.get('fuzzing_engines', [])
- dfsan_engines = 'dataflow' in engines
- sanitizers = self.data.get('sanitizers', [])
- dfsan_sanitizers = 'dataflow' in sanitizers
-
- if dfsan_engines and not dfsan_sanitizers:
- self.error('"dataflow" only specified in "fuzzing_engines" must also be '
- 'specified in "sanitizers" or in neither.')
- return
-
- if dfsan_sanitizers and not dfsan_engines:
- self.error('"dataflow" only specified in "sanitizers" must also be '
- 'specified in "fuzzing_engines" or in neither.')
- return
-
def check_project_yaml_constants(self):
"""Returns True if certain sections only have certain constant values."""
for section, allowed_constants in self.SECTIONS_AND_CONSTANTS.items():