diff options
| author |  Thomas Jost <schnouki@schnouki.net> | 2012-02-21 20:35:35 +0100 |
|---|---|---|
| committer |  David Bremner <bremner@debian.org> | 2012-03-11 22:13:48 -0300 |
| commit | f34613ea833196922a38cf04cd2ee766a562a410 (patch) | |
| tree | 0c779ee8afe7758ccf0dd6ba56f3503f8e507687 /test | |
| parent | 4d136995cebb3a339faf844fa3106f398562aad7 (diff) | |
build: Require gmime >= 2.6.7
gmime-2.6 had a bug [1] which made it impossible to tell why a signature
verification failed when the signer key was unavailable (empty "sigstatus" field
in the JSON output). Since 00b5623d the corresponding test is marked as broken
when using gmime-2.6 (2.4 is fine).
This bug has been fixed in gmime 2.6.5, which is now the minimal gmime-2.6
version required for building notmuch (gmime-2.4 is still available). As a
consequence the version check in test/crypto can be removed.
[Added by db]
Although less unambigously a bug, Gmime 2.6 prior to 2.6.7 also was
more strict about parsing, and rejected messages with initial "From "
headers. This restriction is relaxed in [2]. For reasons explained in [3],
we want to keep this more relaxed parsing for now.
[1] https://bugzilla.gnome.org/show_bug.cgi?id=668085
[2] d311f576baf750476e06e9a1367a2dc1793ea7eb">http://git.gnome.org/browse/gmime/commit/?id=d311f576baf750476e06e9a1367a2dc1793ea7eb
[3] id:"1331385931-1610-1-git-send-email-david@tethera.net"
Diffstat (limited to 'test')
| -rwxr-xr-x | test/crypto | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/test/crypto b/test/crypto index 1dbb60a0..6723ef87 100755 --- a/test/crypto +++ b/test/crypto @@ -104,8 +104,6 @@ test_expect_equal \ "$expected" test_begin_subtest "signature verification with signer key unavailable" -# this is broken with current versions of gmime-2.6 -(ldd $(which notmuch) | grep -Fq gmime-2.6) && test_subtest_known_broken # move the gnupghome temporarily out of the way mv "${GNUPGHOME}"{,.bak} output=$(notmuch show --format=json --verify subject:"test signed message 001" \ |