diff options
| author |  Michal Sojka <sojkam1@fel.cvut.cz> | 2014-05-26 16:05:57 +0200 |
|---|---|---|
| committer |  David Bremner <david@tethera.net> | 2014-08-16 17:45:16 -0700 |
| commit | 028c56061e820211f5757a49bf4da30198b29e29 (patch) | |
| tree | d9e35460b71fef0535ae727745eb50e12864e6dd /test | |
| parent | 61993923b4b2e8c9871cc60681e91896c55e169c (diff) | |
Make parsing of References and In-Reply-To header less error prone
According to RFC2822 References and In-Reply-To headers are supposed
to contain one or more Message-IDs, however older RFC822 allowed
almost any content. When both References and In-Reply-To headers ends
with something else that a Message-ID (see e.g. [1]), the thread
structure presented by notmuch is incorrect. The reason is that
notmuch treats this case as if the email contained no "replyto"
information (see _notmuch_database_link_message_to_parents).
This patch changes the parse_references() function to return the last
valid Message-ID encountered rather than NULL resulting from the last
hunk of text not being the Message-ID.
[1] https://lkml.org/lkml/headers/2014/5/19/864
Diffstat (limited to 'test')
| -rwxr-xr-x | test/T510-thread-replies.sh | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/test/T510-thread-replies.sh b/test/T510-thread-replies.sh index d818b89f..1392fbed 100755 --- a/test/T510-thread-replies.sh +++ b/test/T510-thread-replies.sh @@ -138,7 +138,6 @@ expected=`echo "$expected" | notmuch_json_show_sanitize` test_expect_equal_json "$output" "$expected" test_begin_subtest "Ignore garbage at the end of References" -test_subtest_known_broken add_message '[id]="foo@five.com"' \ '[subject]="five"' add_message '[id]="bar@five.com"' \ |