aboutsummaryrefslogtreecommitdiffhomepage
path: root/test/emacs
diff options
context:
space:
mode:
authorGravatar Adam Wolfe Gordon <awg+notmuch@xvx.ca>2012-04-01 09:24:21 -0600
committerGravatar David Bremner <bremner@debian.org>2012-04-02 17:45:27 -0300
commit3737ca6e268e6f45353bfbcc4ac4b1d548c5908d (patch)
treeeb32c649366927334f38ad63b92ccca3a7642682 /test/emacs
parentb45b72aa14394ba346a958da7a74303951b41ed4 (diff)
emacs: Fix two bugs in reply
Bug 1: Replying from alternate addresses ---------------------------------------- The reply code was inconsistent in its use of symbols and strings for header names being passed to message.el functions. This caused the From header to be lookup up incorrectly, causing an additional From header to be added with the user's primary address instead of the correct alternate address. This is fixed by using symbols everywhere, i.e. never using strings for header names when interacting with message.el. This change also removes our use of `mail-header`, since we don't use it anywhere else, and using assq makes it clear how the header lists are expected to work. Bug 2: Duplicate headers in emacs 23.2 -------------------------------------- The message.el code in emacs 23.2 assumes that header names will always be passed as symbols, so our use of strings caused problems. The symptom was that on 23.2 (and presumably on earlier versions) the reply message would end up with two of some headers. Converting everything to symbols also fixes this issue.
Diffstat (limited to 'test/emacs')
-rwxr-xr-xtest/emacs1
1 files changed, 0 insertions, 1 deletions
diff --git a/test/emacs b/test/emacs
index 576bc1f0..30654bb9 100755
--- a/test/emacs
+++ b/test/emacs
@@ -286,7 +286,6 @@ EOF
test_expect_equal_file OUTPUT EXPECTED
test_begin_subtest "Reply from alternate address within emacs"
-test_subtest_known_broken
add_message '[from]="Sender <sender@example.com>"' \
[to]=test_suite_other@notmuchmail.org