diff options
| author |  Sascha Silbe <sascha-pgp@silbe.org> | 2012-06-24 18:29:24 +0200 |
|---|---|---|
| committer |  David Bremner <bremner@debian.org> | 2012-09-01 23:03:11 -0300 |
| commit | 8dd4e9770ec12de9b2e6fc53259375b2d1720f38 (patch) | |
| tree | e21ab9218da4a746ee3cbad782bb77e86c250b2c /lib/filenames.c | |
| parent | 7cd3cd30039b54aefeab3dde83bbf14badaf7a60 (diff) | |
lib: fix NULL checks for filenames iterators
The API documentation (notmuch.h) states that the parameter may be NULL,
but the implementation only checked the current element, potentially
dereferencing a NULL pointer in the process.
Signed-off-by: Sascha Silbe <sascha-pgp@silbe.org>
Diffstat (limited to 'lib/filenames.c')
| -rw-r--r-- | lib/filenames.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/filenames.c b/lib/filenames.c index f1ea2430..4f7c0d85 100644 --- a/lib/filenames.c +++ b/lib/filenames.c @@ -54,7 +54,7 @@ notmuch_filenames_valid (notmuch_filenames_t *filenames) const char * notmuch_filenames_get (notmuch_filenames_t *filenames) { - if (filenames->iterator == NULL) + if ((filenames == NULL) || (filenames->iterator == NULL)) return NULL; return filenames->iterator->string; @@ -63,7 +63,7 @@ notmuch_filenames_get (notmuch_filenames_t *filenames) void notmuch_filenames_move_to_next (notmuch_filenames_t *filenames) { - if (filenames->iterator == NULL) + if ((filenames == NULL) || (filenames->iterator == NULL)) return; filenames->iterator = filenames->iterator->next; |