diff options
| author |  Dmitry Kurochkin <dmitry.kurochkin@gmail.com> | 2012-02-08 20:48:51 +0400 |
|---|---|---|
| committer |  David Bremner <bremner@debian.org> | 2012-02-12 14:01:28 -0400 |
| commit | a5674c21584a32a4f8a8a3e9ea3c3576f772e744 (patch) | |
| tree | d00355707ef3a0cf2350ebc9883e7e9e409cedb4 /emacs | |
| parent | 668b66ec85a649255441f8ab1a6ee5baa680b4e4 (diff) | |
emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions
Recent changes in notmuch-show tagging introduced some code
duplication. The patch cleanups and simplifies
`notmuch-show-archive-thread' function by using
`notmuch-show-tag-all', no longer used function are removed. After
the change, `notmuch-show-archive-thread' function becomes symmetric
with `notmuch-show-archive-message'.
A side effect of these changes is that `notmuch-show-archive-thread'
no longer calls "notmuch tag" for each message in the thread.
Diffstat (limited to 'emacs')
| -rw-r--r-- | emacs/notmuch-show.el | 25 |
1 files changed, 2 insertions, 23 deletions
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 284e9cd1..43408d98 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1690,26 +1690,6 @@ argument, hide all of the messages." (interactive) (backward-button 1)) -(defun notmuch-show-tag-thread-internal (tag &optional remove) - "Add tag to the current set of messages. - -If the remove switch is given, tags will be removed instead of -added." - (goto-char (point-min)) - (let ((op (if remove "-" "+"))) - (loop do (notmuch-show-tag-message (concat op tag)) - until (not (notmuch-show-goto-message-next))))) - -(defun notmuch-show-add-tag-thread (tag) - "Add tag to all messages in the current thread." - (interactive) - (notmuch-show-tag-thread-internal tag)) - -(defun notmuch-show-remove-tag-thread (tag) - "Remove tag from all messages in the current thread." - (interactive) - (notmuch-show-tag-thread-internal tag t)) - (defun notmuch-show-next-thread (&optional show-next) "Move to the next item in the search results, if any." (interactive "P") @@ -1737,9 +1717,8 @@ being delivered to the same thread. It does not archive the entire thread, but only the messages shown in the current buffer." (interactive "P") - (if unarchive - (notmuch-show-add-tag-thread "inbox") - (notmuch-show-remove-tag-thread "inbox"))) + (let ((op (if unarchive "+" "-"))) + (notmuch-show-tag-all (concat op "inbox")))) (defun notmuch-show-archive-thread-then-next () "Archive each message in thread, then show next thread from search." |