diff options
author | Justus Winter <4winter@informatik.uni-hamburg.de> | 2011-09-26 03:05:37 +0200 |
---|---|---|
committer | Sebastian Spaeth <Sebastian@SSpaeth.de> | 2011-09-29 09:39:45 +0200 |
commit | 34990908e75f73061753a7f38201a05247a207a1 (patch) | |
tree | ff6aeefbd97070b92d54d3fe68a35063ffbfa5ae /bindings | |
parent | f88d985e507a96b5179c2de793b9b75da55457a3 (diff) |
python: raise a more specific error in Messages.print_messages
Raising Exception is considered bad since the only way to catch
it is to do 'except Exception'. Raising a TypeError is more
appropriate.
Since the format parameter has already been validated, checking
it again is not necessary. Simplify this conditional.
Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
Diffstat (limited to 'bindings')
-rw-r--r-- | bindings/python/notmuch/message.py | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/bindings/python/notmuch/message.py b/bindings/python/notmuch/message.py index 4f93a2a4..e5f60621 100644 --- a/bindings/python/notmuch/message.py +++ b/bindings/python/notmuch/message.py @@ -187,7 +187,7 @@ class Messages(object): set_end = "]" set_sep = ", " else: - raise Exception + raise TypeError("format must be either 'text' or 'json'") first_set = True @@ -208,10 +208,8 @@ class Messages(object): if (match or entire_thread): if format.lower() == "text": sys.stdout.write(msg.format_message_as_text(indent)) - elif format.lower() == "json": - sys.stdout.write(msg.format_message_as_json(indent)) else: - raise NotmuchError + sys.stdout.write(msg.format_message_as_json(indent)) next_indent = indent + 1 # get replies and print them also out (if there are any) |