diff options
author | Justus Winter <4winter@informatik.uni-hamburg.de> | 2012-01-22 06:14:57 +0100 |
---|---|---|
committer | Justus Winter <4winter@informatik.uni-hamburg.de> | 2012-01-22 06:14:57 +0100 |
commit | 8015cbff263606f009b5750d23b28ee332c25db8 (patch) | |
tree | a0af581013ad6cc8f302fb145c2761f593c83772 /bindings/python/notmuch/thread.py | |
parent | 871fc32837d1e734895bef5f89040b5b874ae473 (diff) |
python: fix error handling
Before 3434d1940 the return values of libnotmuch functions were
declared as c_void_p and the code checking for errors compared the
returned value to None, which is the ctypes equivalent of a NULL
pointer.
But said commit wrapped all the data types in python classes and the
semantic changed in a subtle way. If a function returns NULL, the
wrapped python value is falsish, but no longer equal to None.
Diffstat (limited to 'bindings/python/notmuch/thread.py')
-rw-r--r-- | bindings/python/notmuch/thread.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/bindings/python/notmuch/thread.py b/bindings/python/notmuch/thread.py index e81ff1bd..104710c4 100644 --- a/bindings/python/notmuch/thread.py +++ b/bindings/python/notmuch/thread.py @@ -97,7 +97,7 @@ class Threads(Python3StringMixIn): :TODO: Make the iterator work more than once and cache the tags in the Python object.(?) """ - if threads_p is None: + if not threads_p: raise NotmuchError(STATUS.NULL_POINTER) self._threads = threads_p @@ -228,7 +228,7 @@ class Thread(object): automatically delete the parent object once all derived objects are dead. """ - if thread_p is None: + if not thread_p: raise NotmuchError(STATUS.NULL_POINTER) self._thread = thread_p #keep reference to parent, so we keep it alive @@ -289,7 +289,7 @@ class Thread(object): msgs_p = Thread._get_toplevel_messages(self._thread) - if msgs_p is None: + if not msgs_p: raise NotmuchError(STATUS.NULL_POINTER) return Messages(msgs_p, self) |