diff options
author | Justus Winter <4winter@informatik.uni-hamburg.de> | 2012-01-22 14:09:35 +0100 |
---|---|---|
committer | David Bremner <bremner@debian.org> | 2012-01-23 07:44:08 -0400 |
commit | 221c7e0b38177f5f1dbf0561580c15e8aaa49004 (patch) | |
tree | b6c5439e552c6c3068ff38c55ab2c9bf01b21e62 /bindings/python/notmuch/message.py | |
parent | ffce9b7c25b9b44ec026b67d96e44cae09c99efe (diff) |
python: fix error handling
Before 3434d1940 the return values of libnotmuch functions were
declared as c_void_p and the code checking for errors compared the
returned value to None, which is the ctypes equivalent of a NULL
pointer.
But said commit wrapped all the data types in python classes and the
semantic changed in a subtle way. If a function returns NULL, the
wrapped python value is falsish, but no longer equal to None.
Backported from master to 0.11.
Diffstat (limited to 'bindings/python/notmuch/message.py')
-rw-r--r-- | bindings/python/notmuch/message.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/bindings/python/notmuch/message.py b/bindings/python/notmuch/message.py index ce8e7181..5540df3e 100644 --- a/bindings/python/notmuch/message.py +++ b/bindings/python/notmuch/message.py @@ -116,7 +116,7 @@ class Messages(object): :TODO: Make the iterator work more than once and cache the tags in the Python object.(?) """ - if msgs_p is None: + if not msgs_p: raise NotmuchError(STATUS.NULL_POINTER) self._msgs = msgs_p @@ -321,7 +321,7 @@ class Message(object): automatically delete the parent object once all derived objects are dead. """ - if msg_p is None: + if not msg_p: raise NotmuchError(STATUS.NULL_POINTER) self._msg = msg_p #keep reference to parent, so we keep it alive @@ -380,7 +380,7 @@ class Message(object): msgs_p = Message._get_replies(self._msg) - if msgs_p is None: + if not msgs_p: return None return Messages(msgs_p, self) |