diff options
author | Niklas Haas <git@haasn.xyz> | 2017-09-28 11:53:57 +0200 |
---|---|---|
committer | Kevin Mitchell <kevmitch@gmail.com> | 2017-12-15 22:28:47 -0800 |
commit | ba1943ac00ed20a568270f8930811c1eac08f66a (patch) | |
tree | d3cd2e11c7bbb2d6e8c6f4eea08daa9d0d91107c /stream | |
parent | d744dca5379c0876cb5adef7ffa41c1bc95e8158 (diff) |
msg: reinterpret a bunch of message levels
I've decided that MP_TRACE means “noisy spam per frame”, whereas
MP_DBG just means “more verbose debugging messages than MSGL_V”.
Basically, MSGL_DBG shouldn't create spam per frame like it currently
does, and MSGL_V should make sense to the end-user and provide mostly
additional informational output.
MP_DBG is basically what I want to make the new default for --log-file,
so the cut-off point for MP_DBG is if we probably want to know if for
debugging purposes but the user most likely doesn't care about on the
terminal.
Also, the debug callbacks for libass and ffmpeg got bumped in their
verbosity levels slightly, because being external components they're a
bit less relevant to mpv debugging, and a bit too over-eager in what
they consider to be relevant information.
I exclusively used the "try it on my machine and remove messages from
MSGL_* until it does what I want it to" approach of refactoring, so
YMMV.
Diffstat (limited to 'stream')
-rw-r--r-- | stream/stream.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/stream/stream.c b/stream/stream.c index 29234e59a5..44a773cd1f 100644 --- a/stream/stream.c +++ b/stream/stream.c @@ -251,7 +251,7 @@ static int open_internal(const stream_info_t *sinfo, const char *url, int flags, MP_VERBOSE(s, "Opening %s\n", url); if ((s->mode & STREAM_WRITE) && !sinfo->can_write) { - MP_VERBOSE(s, "No write access implemented.\n"); + MP_DBG(s, "No write access implemented.\n"); talloc_free(s); return STREAM_NO_MATCH; } @@ -273,7 +273,7 @@ static int open_internal(const stream_info_t *sinfo, const char *url, int flags, if (s->mime_type) MP_VERBOSE(s, "Mime-type: '%s'\n", s->mime_type); - MP_VERBOSE(s, "Stream opened successfully.\n"); + MP_DBG(s, "Stream opened successfully.\n"); *ret = s; return STREAM_OK; |