diff options
author | wm4 <wm4@nowhere> | 2017-12-29 17:19:25 +0100 |
---|---|---|
committer | Kevin Mitchell <kevmitch@gmail.com> | 2018-01-02 14:27:37 -0800 |
commit | 6aad532aa39481a8100910612fad039dd75236b9 (patch) | |
tree | 53c790d6c66917e66039c25a13cdf27f90bbf0d9 /options/m_config.h | |
parent | 3bf7df4a5e1f46248c78e9e596cd8dab6ff57356 (diff) |
options: move most subtitle and OSD rendering options to sub structs
Remove them from the big MPOpts struct and move them to their sub
structs. In the places where their fields are used, create a private
copy of the structs, instead of accessing the semi-deprecated global
option struct instance (mpv_global.opts) directly.
This actually makes accessing these options finally thread-safe. They
weren't even if they should have for years. (Including some potential
for undefined behavior when e.g. the OSD font was changed at runtime.)
This is mostly transparent. All options get moved around, but most users
of the options just need to access a different struct (changing sd.opts
to a different type changes a lot of uses, for example).
One thing which has to be considered and could cause potential
regressions is that the new option copies must be explicitly updated.
sub_update_opts() takes care of this for example.
Another thing is that writing to the option structs manually won't work,
because the changes won't be propagated to other copies. Apparently the
only affected case is the implementation of the sub-step command, which
tries to change sub_delay. Handle this one explicitly (osd_changed()
doesn't need to be called anymore, because changing the option triggers
UPDATE_OSD, and updates the OSD as a consequence). The way the option
value is propagated is rather hacky, but for now this will do.
Diffstat (limited to 'options/m_config.h')
-rw-r--r-- | options/m_config.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/options/m_config.h b/options/m_config.h index fc32ca5bf0..6c4e9b759f 100644 --- a/options/m_config.h +++ b/options/m_config.h @@ -201,6 +201,10 @@ int m_config_option_requires_param(struct m_config *config, bstr name); // Notify m_config_cache users that the option has (probably) changed its value. void m_config_notify_change_co(struct m_config *config, struct m_config_option *co); +// Like m_config_notify_change_co(), but automatically find the option by its +// pointer within the global option struct (config->optstruct). In practice, +// it means it works only on fields in MPContext.opts. +void m_config_notify_change_opt_ptr(struct m_config *config, void *ptr); bool m_config_is_in_group(struct m_config *config, const struct m_sub_options *group, |