diff options
author | wm4 <wm4@nowhere> | 2017-06-14 16:20:56 +0200 |
---|---|---|
committer | wm4 <wm4@nowhere> | 2017-06-14 21:08:59 +0200 |
commit | 6489b112ad8f3edf19bc7e741980414d8e93dcbd (patch) | |
tree | bd333b42fa09239f63dfd49c56a4b16d7717e74c | |
parent | 5b3ca8ed419a95316719cad5cf3eca8bf86f2eae (diff) |
dec_audio, ad_lavc: change license to LGPL
All relevant authors of the current code have agreed.
As always, there are the usual historical artifacts that could be
mentioned. For example, there used to be a large number of decoders
by various authors who were not asked, but whose code was all 100%
removed. (Mostly due to FFmpeg providing all codecs.)
One point of contention is that Nick Kurshev might have refactored the
old audio decoder code in 2001. Basically, there are hints that it might
have been done by him, such as Arpi's commit message stating that the
code was imported from MPlayerXP (Nick's fork), or all the files having
his name in the "maintainer" field. On the other hand, the murky history
of ad.h weakens this - it could be that Arpi started this work, and Nick
took it (and possibly finished it).
In any case, Nick could not be reached, so there is no agreement for
LGPL relicensing from him. We're changing the license anyway, and assume
that his change in itself is not copyrightable. He only moved code, and
in addition used the equivalent video decoder framework (done by Arpi,
who agreed) as template. For example, ad_functions_s was basically
vd_functions_s, which the signature of the decode callback changed to
the same as audio_decode(). ad_functions_s also had a comment that said
it interfaces with "video decoder drivers" (I'm fixing this comment in
this commit).
I verified that no additional code was added that is copyright-relevant,
still in today's code, and not copied from the existing code at the time
(either from the previous audio decoder code or the video framework
code). What apparently matters here is that none of the old code was not
written by Nick, and the authors of the old code have given his
agreement, and (probably) that Nick didn't add actual new code (none
that would have survived), that was not trivially based on the old one
(i.e. no new copyrightable "work").
A copyright expert told me that this kind of change can be considered
not relevant for copyright, so here we go.
Rewriting this would end with the same code anyway, and the naming
conventions can't be copyrighted.
-rw-r--r-- | Copyright | 4 | ||||
-rw-r--r-- | audio/decode/ad.h | 2 | ||||
-rw-r--r-- | audio/decode/ad_lavc.c | 14 | ||||
-rw-r--r-- | audio/decode/dec_audio.c | 14 | ||||
-rw-r--r-- | audio/decode/dec_audio.h | 14 |
5 files changed, 24 insertions, 24 deletions
@@ -58,9 +58,9 @@ or removed. All new contributions to these files are implied to be LGPLv2.1+. LGPL relicensing status: audio/decode/ad.h LGPL - audio/decode/ad_lavc.c very hard (nick's changes) + audio/decode/ad_lavc.c LGPL audio/decode/ad_spdif.c LGPL - audio/decode/dec_audio.* very hard (nick's changes) + audio/decode/dec_audio.* LGPL audio/filter/af.* must be killed (main author disagreed) audio/filter/af_channel.c must be killed (main author disagreed) audio/filter/af_equalizer.c must be killed (main author disagreed) diff --git a/audio/decode/ad.h b/audio/decode/ad.h index 25f1239aa8..0af05e1827 100644 --- a/audio/decode/ad.h +++ b/audio/decode/ad.h @@ -28,7 +28,7 @@ struct mp_decoder_list; -/* interface of video decoder drivers */ +/* interface of audio decoder drivers */ struct ad_functions { const char *name; void (*add_decoders)(struct mp_decoder_list *list); diff --git a/audio/decode/ad_lavc.c b/audio/decode/ad_lavc.c index 7f3abfd612..6f28d062ee 100644 --- a/audio/decode/ad_lavc.c +++ b/audio/decode/ad_lavc.c @@ -1,18 +1,18 @@ /* * This file is part of mpv. * - * mpv is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. + * mpv is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. * * mpv is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. + * GNU Lesser General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with mpv. If not, see <http://www.gnu.org/licenses/>. + * You should have received a copy of the GNU Lesser General Public + * License along with mpv. If not, see <http://www.gnu.org/licenses/>. */ #include <stdio.h> diff --git a/audio/decode/dec_audio.c b/audio/decode/dec_audio.c index fce9ef94e0..1351cb8ecd 100644 --- a/audio/decode/dec_audio.c +++ b/audio/decode/dec_audio.c @@ -1,18 +1,18 @@ /* * This file is part of mpv. * - * mpv is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. + * mpv is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. * * mpv is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. + * GNU Lesser General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with mpv. If not, see <http://www.gnu.org/licenses/>. + * You should have received a copy of the GNU Lesser General Public + * License along with mpv. If not, see <http://www.gnu.org/licenses/>. */ #include <stdio.h> diff --git a/audio/decode/dec_audio.h b/audio/decode/dec_audio.h index 02447d6742..886b617b58 100644 --- a/audio/decode/dec_audio.h +++ b/audio/decode/dec_audio.h @@ -1,18 +1,18 @@ /* * This file is part of mpv. * - * mpv is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. + * mpv is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. * * mpv is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. + * GNU Lesser General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with mpv. If not, see <http://www.gnu.org/licenses/>. + * You should have received a copy of the GNU Lesser General Public + * License along with mpv. If not, see <http://www.gnu.org/licenses/>. */ #ifndef MPLAYER_DEC_AUDIO_H |